Re: Incorrect pipe for git log graph when using --name-status option

2017-02-13 Thread Jeff King
On Mon, Feb 13, 2017 at 01:43:45PM -0800, hIpPy wrote: > With --name-status: I'm sorry if I nitpick here but I think the > --name-status items should either be preceeded and followed by > blank line OR not (as in oneline) but not just preceded (example > below). Yeah, I agree the output is a bit

Re: Incorrect pipe for git log graph when using --name-status option

2017-02-13 Thread hIpPy
On Mon, Feb 13, 2017 at 1:27 PM, Jeff King wrote: > On Mon, Feb 13, 2017 at 01:18:40PM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > I think the problem is specifically related to the "terminator" versus >> > "separator" semantics. Try: >> > >> > git log --graph --name-status --pr

Re: Incorrect pipe for git log graph when using --name-status option

2017-02-13 Thread Jeff King
On Mon, Feb 13, 2017 at 01:18:40PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I think the problem is specifically related to the "terminator" versus > > "separator" semantics. Try: > > > > git log --graph --name-status --pretty=format:%h > > > > versus: > > > > git log --graph --

Re: Incorrect pipe for git log graph when using --name-status option

2017-02-13 Thread Junio C Hamano
Jeff King writes: > I think the problem is specifically related to the "terminator" versus > "separator" semantics. Try: > > git log --graph --name-status --pretty=format:%h > > versus: > > git log --graph --name-status --pretty=tformat:%h > > The latter works fine. The problem seems to happe

Re: Incorrect pipe for git log graph when using --name-status option

2017-02-13 Thread Jeff King
On Mon, Feb 13, 2017 at 12:55:07PM -0800, hIpPy wrote: > I think that requiring to end custom formats with %n with options > is not good. So I think this is a bug. Yes, you don't normally need to do that. I think the problem is specifically related to the "terminator" versus "separator" semantic

Re: Incorrect pipe for git log graph when using --name-status option

2017-02-13 Thread hIpPy
On Mon, Feb 13, 2017 at 11:25 AM, Junio C Hamano wrote: > hIpPy writes: > >> The `git log` command with `graph` and pretty format works correctly >> as expected. >> >> $ git log --graph --pretty=format:'%h' -2 >> * 714a14e >> * 87dce5f >> >> >> However, with `--name-status` option added, there is

Re: Incorrect pipe for git log graph when using --name-status option

2017-02-13 Thread Junio C Hamano
hIpPy writes: > The `git log` command with `graph` and pretty format works correctly > as expected. > > $ git log --graph --pretty=format:'%h' -2 > * 714a14e > * 87dce5f > > > However, with `--name-status` option added, there is a pipe > incorrectly placed after the commit hash (example below). >

Incorrect pipe for git log graph when using --name-status option

2017-02-12 Thread hIpPy
The `git log` command with `graph` and pretty format works correctly as expected. $ git log --graph --pretty=format:'%h' -2 * 714a14e * 87dce5f However, with `--name-status` option added, there is a pipe incorrectly placed after the commit hash (example below). $ git log --graph --pretty=format