Re: I think git show is broken

2012-08-28 Thread Jeff King
On Tue, Aug 28, 2012 at 03:36:26PM -0700, Junio C Hamano wrote: > > As a result, the flag would have no effect in "git log -p > > --quiet" or "git show --quiet". Fix it by setting the > > format flag before the call to setup_revisions. > > This also means that > > git show --name-status -

Re: I think git show is broken

2012-08-28 Thread Junio C Hamano
Jeff King writes: > Yes, that is what's going on. But it's still a regression. There was > some discussion of what --quiet should do here: > > http://thread.gmane.org/gmane.comp.version-control.git/171357 > > which resulted in a patch that took away --quiet. But then this thread: > > http://t

Re: I think git show is broken

2012-08-28 Thread Jeff King
On Tue, Aug 28, 2012 at 01:48:27PM -0400, Matthew Caron wrote: > On 08/28/2012 01:38 PM, Matthew Caron wrote: > >(otherwise, there was a very strange change made to its functionality, > >which the documentation does not reflect) > > Never mind. > > I was looking in the wrong spot. The issue is n

Re: I think git show is broken

2012-08-28 Thread Matthew Caron
On 08/28/2012 01:38 PM, Matthew Caron wrote: (otherwise, there was a very strange change made to its functionality, which the documentation does not reflect) Never mind. I was looking in the wrong spot. The issue is not with --pretty=oneline, it's with --quiet. In 1.7.0.4, --quiet worked like

I think git show is broken

2012-08-28 Thread Matthew Caron
(otherwise, there was a very strange change made to its functionality, which the documentation does not reflect) Old, working git: === $ git --version git version 1.7.0.4 $ git show --quiet --abbrev-commit --pretty=oneline 47a7aee54553fb718c376cfa9d7de4389a391e33 47a7aee Fix hyperlinks for d