Re: I made a flame graph renderer for git's trace2 output

2019-05-21 Thread Jeff Hostetler
On 5/21/2019 10:19 AM, Ævar Arnfjörð Bjarmason wrote: On Mon, May 20 2019, Jeff Hostetler wrote: On 5/10/2019 5:57 PM, Ævar Arnfjörð Bjarmason wrote: On Fri, May 10 2019, Jeff King wrote: On Fri, May 10, 2019 at 05:09:58PM +0200, Ævar Arnfjörð Bjarmason wrote: As noted in TODOs in the

Re: I made a flame graph renderer for git's trace2 output

2019-05-21 Thread Ævar Arnfjörð Bjarmason
On Mon, May 20 2019, Jeff Hostetler wrote: > On 5/10/2019 5:57 PM, Ævar Arnfjörð Bjarmason wrote: >> >> On Fri, May 10 2019, Jeff King wrote: >> >>> On Fri, May 10, 2019 at 05:09:58PM +0200, Ævar Arnfjörð Bjarmason wrote: >>> As noted in TODOs in the script there's various stuff I'd like to

Re: I made a flame graph renderer for git's trace2 output

2019-05-20 Thread Jeff Hostetler
On 5/10/2019 1:00 PM, SZEDER Gábor wrote: On Fri, May 10, 2019 at 12:38:52PM -0400, Derrick Stolee wrote: export GIT_TR2_EVENT=~/git-tr2-event.txt Hrm, better late than never, or at least better late than after it's in a release... Why does an environment variable that is supposed to be s

Re: I made a flame graph renderer for git's trace2 output

2019-05-20 Thread Jeff Hostetler
On 5/10/2019 5:57 PM, Ævar Arnfjörð Bjarmason wrote: On Fri, May 10 2019, Jeff King wrote: On Fri, May 10, 2019 at 05:09:58PM +0200, Ævar Arnfjörð Bjarmason wrote: As noted in TODOs in the script there's various stuff I'd like to do better, and this also shows how we need a lot more trace

Re: I made a flame graph renderer for git's trace2 output

2019-05-10 Thread Ævar Arnfjörð Bjarmason
On Fri, May 10 2019, Jeff King wrote: > On Fri, May 10, 2019 at 05:09:58PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> As noted in TODOs in the script there's various stuff I'd like to do >> better, and this also shows how we need a lot more trace regions to get >> granular data. > > Hmm. My gut

Re: I made a flame graph renderer for git's trace2 output

2019-05-10 Thread Jeff King
On Fri, May 10, 2019 at 05:09:58PM +0200, Ævar Arnfjörð Bjarmason wrote: > As noted in TODOs in the script there's various stuff I'd like to do > better, and this also shows how we need a lot more trace regions to get > granular data. Hmm. My gut reaction was: doesn't "perf record -g make test" a

Re: I made a flame graph renderer for git's trace2 output

2019-05-10 Thread SZEDER Gábor
On Fri, May 10, 2019 at 12:38:52PM -0400, Derrick Stolee wrote: > export GIT_TR2_EVENT=~/git-tr2-event.txt Hrm, better late than never, or at least better late than after it's in a release... Why does an environment variable that is supposed to be set by users have this "TR2" abbreviation in its

Re: I made a flame graph renderer for git's trace2 output

2019-05-10 Thread Derrick Stolee
On 5/10/2019 11:09 AM, Ævar Arnfjörð Bjarmason wrote: > Here's a flamegraph of where git's test suite spends its time on my box: > https://vm.nix.is/~avar/noindex/git-tests.svg > > I hacked up a script for this today to plot trace2 production data, as > noted there it's at: > https://github.com/av

I made a flame graph renderer for git's trace2 output

2019-05-10 Thread Ævar Arnfjörð Bjarmason
Here's a flamegraph of where git's test suite spends its time on my box: https://vm.nix.is/~avar/noindex/git-tests.svg I hacked up a script for this today to plot trace2 production data, as noted there it's at: https://github.com/avar/FlameGraph/tree/stackcollapse-git-tr2-event What are flamegrap