Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-10 Thread René Scharfe
Am 10.08.19 um 14:40 schrieb Carlo Arenas: > On Sat, Aug 10, 2019 at 12:57 AM René Scharfe wrote: >> I don't understand why my performance is lower by factor 2.5 than yours >> for all perl regex tests except 7820.15 (your 7820.4), where my system >> is two times faster. Debian Testing, GCC 9.1.0,

Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-10 Thread Carlo Arenas
On Sat, Aug 10, 2019 at 12:57 AM René Scharfe wrote: > > Am 10.08.19 um 05:05 schrieb Carlo Arenas: > > in macOS (obviously testing without NED) the following is the output > > of (a hacked version) of p7801 for maint (against chromium's > > repository), with René's patch on top > > Do you mean p7

Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-10 Thread René Scharfe
Am 10.08.19 um 05:05 schrieb Carlo Arenas: > in macOS (obviously testing without NED) the following is the output > of (a hacked version) of p7801 for maint (against chromium's > repository), with René's patch on top Do you mean p7820? And what did you change? Looking at the results you removed

Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-09 Thread Carlo Arenas
On Fri, Aug 9, 2019 at 2:26 PM Johannes Schindelin wrote: > > FWIW I am very much in favor of this approach. FWIW this is (almost) exactly what I had in mind with my first reply, except I wanted to make setting of the global context be conditioned to having NED enabled to avoid possible performan

Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-09 Thread Johannes Schindelin
Hi, On Fri, 9 Aug 2019, René Scharfe wrote: > Am 09.08.19 um 13:24 schrieb Carlo Arenas: > > disregard this version, it still broken (and wouldn't even build on > > some cases), the reasons why are still unclear though but at least it > > might > > seem from the last known run in windows that se

Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-09 Thread Junio C Hamano
René Scharfe writes: > So how about starting stupidly simple? You can test it everywhere, it > just needs libpcre2. It works without that library as well (tested with > "make USE_LIBPCRE= USE_LIBPCRE2= test"), but doesn't allocate anything > in that case, of course. The character tables leak f

Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-09 Thread René Scharfe
Am 09.08.19 um 13:24 schrieb Carlo Arenas: > disregard this version, it still broken (and wouldn't even build on > some cases), the reasons why are still unclear though but at least it > might > seem from the last known run in windows that segfaults were prevented > at last and something was still

Re: [RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-09 Thread Carlo Arenas
disregard this version, it still broken (and wouldn't even build on some cases), the reasons why are still unclear though but at least it might seem from the last known run in windows that segfaults were prevented at last and something was still off enough to trigger a BUG (shouldn't be a concern w

[RFC PATCH v5 0/3] grep: almost no more leaks, hopefully no crashes

2019-08-08 Thread Carlo Marcelo Arenas Belón
This series is a candidate reroll for cb/pcre2-chartables-leakfix, that hopefully addresses the root cause of the problem reported by Dscho in Windows, where the PCRE2 library wasn't aware of the custom allocator and was returning a pointer created with the system malloc but passing it to

[PATCH v3 0/2] Last big GIT_TEST_PROTOCOL_VERSION=2 fix, hopefully

2019-03-26 Thread Jonathan Tan
Peff says in [1]: > But isn't this line: > > > + if (version == protocol_v2) { > > +- if (shallow && shallow->nr) > > ++ if (shallow->nr) > > BUG("Protocol V2 does not provide shallows at > > this point in the fetch"); > >

Re: [PATCH v2 0/2] Last big GIT_TEST_PROTOCOL_VERSION=2 fix, hopefully

2019-03-26 Thread Jeff King
On Tue, Mar 26, 2019 at 10:53:24AM -0700, Jonathan Tan wrote: > Updated to remove the unnecessary NULL check and memory leak that Peff > noticed [1]. > > (Only commit 2/2 is changed, so the range-diff only shows 1 commit.) But isn't this line: > + if (version == protocol_v2) { >

[PATCH v2 0/2] Last big GIT_TEST_PROTOCOL_VERSION=2 fix, hopefully

2019-03-26 Thread Jonathan Tan
Updated to remove the unnecessary NULL check and memory leak that Peff noticed [1]. (Only commit 2/2 is changed, so the range-diff only shows 1 commit.) [1] https://public-inbox.org/git/20190326052011.gb1...@sigill.intra.peff.net/ Jonathan Tan (2): fetch-pack: call prepare_shallow_info only if

[PATCH 0/2] Last big GIT_TEST_PROTOCOL_VERSION=2 fix, hopefully

2019-03-25 Thread Jonathan Tan
This is built on master+jt/test-protocol-version, but should apply cleanly to master. After [1] and this patch set, there is only one more small thing to fix or mark GIT_TEST_PROTOCOL_VERSION=0 at master+jt/test-protocol-version. This is very similar to [2], which was neither reviewed nor merged,

HOPEFULLY

2018-11-01 Thread Zongo Daniel
Hello I am Zongo Daniel and work with BICIAB BANK Of Burkina Faso. I have an important business proposal that will be of mutual benefit. Please send me your direct number or your personal email so i can tell you more about my proposal. It is very important we communicate and you will be very glad

Hopefully

2018-03-04 Thread Rita Micheal
Dear friend, My name is Mr Micheal Rita, I am the Bill and Exchange (assistant) Manager of Bank of Africa Ouagadougou, Burkina Faso. In my department I discovered an abandoned sum of teen million five hundred thousand United State of American dollars (10.5MILLION USA DOLLARS) in an account that be

Hopefully

2017-06-25 Thread Rita Micheal
Dear friend, My name is Mr Micheal Rita, I am the Bill and Exchange (assistant) Manager of Bank of Africa Ouagadougou, Burkina Faso. In my department I discovered an abandoned sum of teen million five hundred thousand United State of American dollars (10.5MILLION USA DOLLARS) in an account that be

Hopefully

2017-03-20 Thread Rita Micheal
Dear friend, My name is Mr Micheal Rita, I am the Bill and Exchange (assistant) Manager of Bank of Africa Ouagadougou, Burkina Faso. In my department I discovered an abandoned sum of teen million five hundred thousand United State of American dollars (10.5MILLION USA DOLLARS) in an account that be

Hopefully

2017-02-17 Thread Rita Micheal
Dear friend, My name is Mr Micheal Rita, I am the Bill and Exchange (assistant) Manager of Bank of Africa Ouagadougou, Burkina Faso. In my department I discovered an abandoned sum of teen million five hundred thousand United State of American dollars (10.5MILLION USA DOLLARS) in an account that be

Hopefully

2017-01-28 Thread Rita Micheal
Dear friend, My name is Mr Rita Micheal, I am the Bill and Exchange (assistant) Manager of Bank of Africa Ouagadougou, Burkina Faso. In my department I discovered an abandoned sum of teen million five hundred thousand United State of American dollars (10.5MILLION USA DOLLARS) in an account that be