Re: Git v2.11.0 breaks max depth nested alternates

2016-12-05 Thread Philip Oakley
From: "Jeff King" On Sun, Dec 04, 2016 at 11:22:52AM -, Philip Oakley wrote: > Ever since 722ff7f876 (receive-pack: quarantine objects until > pre-receive accepts, 2016-10-03, v2.11.0), Git has been quarantining > objects and packs received during an incoming push into a separate > objects

Re: Git v2.11.0 breaks max depth nested alternates

2016-12-04 Thread Jeff King
On Sun, Dec 04, 2016 at 11:22:52AM -, Philip Oakley wrote: > > Ever since 722ff7f876 (receive-pack: quarantine objects until > > pre-receive accepts, 2016-10-03, v2.11.0), Git has been quarantining > > objects and packs received during an incoming push into a separate > > objects directory and

Re: Git v2.11.0 breaks max depth nested alternates

2016-12-04 Thread Jeff King
On Sun, Dec 04, 2016 at 01:37:00AM -0800, Kyle J. McKay wrote: > On Dec 3, 2016, at 20:55, Jeff King wrote: > > > So I do think this is worth dealing with, but I'm also curious why > > you're hitting the depth-5 limit. I'm guessing it has to do with hosting > > a hierarchy of related repos. But i

Re: Git v2.11.0 breaks max depth nested alternates

2016-12-04 Thread Philip Oakley
From: "Kyle J. McKay" Sent: Sunday, December 04, 2016 12:24 AM The recent addition of pre-receive quarantining breaks nested alternates that are already at the maximum alternates nesting depth. In the file sha1_file.c in the function link_alt_odb_entries we have this: > if (depth > 5) { >

Re: Git v2.11.0 breaks max depth nested alternates

2016-12-04 Thread Kyle J. McKay
On Dec 3, 2016, at 20:55, Jeff King wrote: So I do think this is worth dealing with, but I'm also curious why you're hitting the depth-5 limit. I'm guessing it has to do with hosting a hierarchy of related repos. But is your system then always in danger of busting the 5-limit if people create

Re: Git v2.11.0 breaks max depth nested alternates

2016-12-03 Thread Jeff King
On Sat, Dec 03, 2016 at 04:24:02PM -0800, Kyle J. McKay wrote: > When the incoming quarantine takes place the current objects directory > is demoted to an alternate thereby increasing its depth (and any > alternates it references) by one and causing any object store that was > previously at

Git v2.11.0 breaks max depth nested alternates

2016-12-03 Thread Kyle J. McKay
The recent addition of pre-receive quarantining breaks nested alternates that are already at the maximum alternates nesting depth. In the file sha1_file.c in the function link_alt_odb_entries we have this: > if (depth > 5) { > error("%s: ignoring alternate object stores, nesting too