Re: Git status parse error after v.2.22.0 upgrade

2019-06-25 Thread Phillip Wood
On 13/06/2019 18:43, Phillip Wood wrote: On 13/06/2019 17:24, Jeff King wrote: On Thu, Jun 13, 2019 at 09:05:16AM -0700, Junio C Hamano wrote: Two issues "the sequencer" folks may want to address are (1) make the one that reads an irrelevant/stale 'todo' file more careful to ignore er

Re: Git status parse error after v.2.22.0 upgrade

2019-06-13 Thread Jeff King
On Thu, Jun 13, 2019 at 06:43:41PM +0100, Phillip Wood wrote: > >> (2) make the sequencer machinery more careful to clean up after it > >> is done or it is aborted (for example, "git reset --hard" > >> could remove these state files preemptively even when a rebase > >> is not in p

Re: Git status parse error after v.2.22.0 upgrade

2019-06-13 Thread Phillip Wood
On 13/06/2019 17:24, Jeff King wrote: > On Thu, Jun 13, 2019 at 09:05:16AM -0700, Junio C Hamano wrote: > >> aleksan...@ledovskis.lv writes: >> >>> My repo indeed contains a ".git/sequencer/todo" file which >>> contains references to commits long-gone (i.e., rebased). >>> Renaming or deleting this

Re: Git status parse error after v.2.22.0 upgrade

2019-06-13 Thread Aleksandrs Ļedovskis
On Thu, Jun 13, 2019 at 09:05:16AM -0700, Junio C Hamano wrote: > are you getting it when you run "git status" command??? Yes, the regular old porcelain `git-status(1)`. $ git status error: could not parse '<>' On branch <> nothing to commit, working tree clean -- Best, Aleksandrs Ļedovskis

Re: Git status parse error after v.2.22.0 upgrade

2019-06-13 Thread SZEDER Gábor
On Thu, Jun 13, 2019 at 09:05:16AM -0700, Junio C Hamano wrote: > aleksan...@ledovskis.lv writes: > > > My repo indeed contains a ".git/sequencer/todo" file which > > contains references to commits long-gone (i.e., rebased). > > Renaming or deleting this file stops whines about "error: could > > n

Re: Git status parse error after v.2.22.0 upgrade

2019-06-13 Thread Jeff King
On Thu, Jun 13, 2019 at 09:05:16AM -0700, Junio C Hamano wrote: > aleksan...@ledovskis.lv writes: > > > My repo indeed contains a ".git/sequencer/todo" file which > > contains references to commits long-gone (i.e., rebased). > > Renaming or deleting this file stops whines about "error: could > >

Re: Git status parse error after v.2.22.0 upgrade

2019-06-13 Thread Junio C Hamano
aleksan...@ledovskis.lv writes: > My repo indeed contains a ".git/sequencer/todo" file which > contains references to commits long-gone (i.e., rebased). > Renaming or deleting this file stops whines about "error: could > not parse". Interesting. So in short, when the repository has leftover sequ

Re: Git status parse error after v.2.22.0 upgrade

2019-06-13 Thread aleksandrs
Hello, Managed to repro this problem on my private repo too. Bisect points to b51a0fdc3822c2ef260f6d496b6df6d33b101e8a However, I think the real culprit is 4a72486de97b5c6b0979b2b51e50c268bdb0d4f6, specifically `parse_insn_line` call. My repo indeed contains a ".git/sequencer/todo" file which c

Re: Git status parse error after v.2.22.0 upgrade

2019-06-12 Thread Johannes Schindelin
Hi Espen, On Wed, 12 Jun 2019, Espen Antonsen wrote: > I don't have any hooks, just the default sample scripts. GIT_TRACE > doesn't show anything else. Okay, it was just a guess. And here is another guess: unless you impart with more details about your test case, I guess there is little anybody

Re: Git status parse error after v.2.22.0 upgrade

2019-06-12 Thread Espen Antonsen
I don't have any hooks, just the default sample scripts. GIT_TRACE doesn't show anything else. On Tue, 11 Jun 2019, at 21:28, Johannes Schindelin wrote: > Hi Espen, > > On Tue, 11 Jun 2019, Espen Antonsen wrote: > > > Seeing an error after upgrading to git v2.22.0. > > > > git status shows “err

Re: Git status parse error after v.2.22.0 upgrade

2019-06-11 Thread Johannes Schindelin
Hi Espen, On Tue, 11 Jun 2019, Espen Antonsen wrote: > Seeing an error after upgrading to git v2.22.0. > > git status shows “error: could not parse ‘*a commit message from 2012*’” > > Downgrading to v.2.21.0 does not yield this message for git status. > > I can only replicate this in a private re

Git status parse error after v.2.22.0 upgrade

2019-06-11 Thread Espen Antonsen
Seeing an error after upgrading to git v2.22.0. git status shows “error: could not parse ‘*a commit message from 2012*’” Downgrading to v.2.21.0 does not yield this message for git status. I can only replicate this in a private repo I have so far. Unable to share the repo but can debug if you n