Re: Git 2.7.0 gitignore behaviour regression

2016-01-06 Thread Duy Nguyen
On Thu, Jan 7, 2016 at 9:04 AM, Jeff King wrote: >> Yup, an area that is reasonably isolated from the remainder of the system >> like >> this might be a good starting point. But I suspect that the invasion needs to >> happen in the opposite direction in this particular case before it happens. >>

Re: Git 2.7.0 gitignore behaviour regression

2016-01-06 Thread Jeff King
[+cc Carlos and Shawn for libgit2/JGit talk] On Wed, Jan 06, 2016 at 10:58:37AM -0800, Junio C Hamano wrote: > On Wed, Jan 6, 2016 at 2:03 AM, Duy Nguyen wrote: > > > > Yeah.. it looks like libgit2's gitignore support was written new, not > > imported from C Git, so behavior differences (especia

Re: Git 2.7.0 gitignore behaviour regression

2016-01-06 Thread Junio C Hamano
On Wed, Jan 6, 2016 at 2:03 AM, Duy Nguyen wrote: > > On Wed, Jan 6, 2016 at 4:50 PM, Mike McQuaid wrote: > > it’s also a big area where libgit2 was inconsistent with Git’s behaviour on > > either of those versions too. > > Yeah.. it looks like libgit2's gitignore support was written new, not >

Re: Git 2.7.0 gitignore behaviour regression

2016-01-06 Thread Duy Nguyen
On Wed, Jan 6, 2016 at 4:50 PM, Mike McQuaid wrote: > it’s also a big area where libgit2 was inconsistent with Git’s behaviour on > either of those versions too. Yeah.. it looks like libgit2's gitignore support was written new, not imported from C Git, so behavior differences (especially in corn

Re: Git 2.7.0 gitignore behaviour regression

2016-01-06 Thread Mike McQuaid
> On 6 Jan 2016, at 09:42, Duy Nguyen wrote: > > Yeah.. I think it's the only relevant commit in 2.7.0 cycle anyway. > These patterns "/a" followed by "!/a/*" were wrecking my head. But I > finally decided 2.7 output makes more sense. You asked to un-ignore > everything inside 'a' so we can't tr

Re: Git 2.7.0 gitignore behaviour regression

2016-01-06 Thread Duy Nguyen
On Tue, Jan 5, 2016 at 10:06 PM, Jeff King wrote: > On Tue, Jan 05, 2016 at 02:40:16PM +, Mike McQuaid wrote: > >> Homebrew has a series of convoluted .gitignore rules due to our >> special/weird use-case of wanting to ignore everything in a working >> directory except a select few files/direc

Re: Git 2.7.0 gitignore behaviour regression

2016-01-05 Thread Jeff King
On Tue, Jan 05, 2016 at 02:40:16PM +, Mike McQuaid wrote: > Homebrew has a series of convoluted .gitignore rules due to our > special/weird use-case of wanting to ignore everything in a working > directory except a select few files/directories. We experienced a bug > with our .gitignore file f

Git 2.7.0 gitignore behaviour regression

2016-01-05 Thread Mike McQuaid
Hi folks, Firstly, thanks for all your hard work on Git. It makes my life much easier. Homebrew has a series of convoluted .gitignore rules due to our special/weird use-case of wanting to ignore everything in a working directory except a select few files/directories. We experienced a bug with o