Re: [PATCH] linear-assignment: fix potential out of bounds memory access (was: Re: Git 2.19 Segmentation fault 11 on macOS)

2018-09-13 Thread Thomas Gummerer
On 09/12, Johannes Schindelin wrote: > Hi Thomas, > > [quickly, as I will go back to a proper vacation after this] Sorry about interrupting your vacation, enjoy wherever you are! :) > On Wed, 12 Sep 2018, Thomas Gummerer wrote: > > > diff --git a/linear-assignment.c b/linear-assignment.c > > in

Re: [PATCH] linear-assignment: fix potential out of bounds memory access (was: Re: Git 2.19 Segmentation fault 11 on macOS)

2018-09-13 Thread Eric Sunshine
On Wed, Sep 12, 2018 at 3:01 PM Thomas Gummerer wrote: > Subject: [PATCH] linear-assignment: fix potential out of bounds memory access > > Currently the 'compute_assignment()' function can may read memory out "can may"? > of bounds, even if used correctly. Namely this happens when we only > hav

Re: [PATCH] linear-assignment: fix potential out of bounds memory access (was: Re: Git 2.19 Segmentation fault 11 on macOS)

2018-09-12 Thread Johannes Schindelin
Hi Thomas, [quickly, as I will go back to a proper vacation after this] On Wed, 12 Sep 2018, Thomas Gummerer wrote: > diff --git a/linear-assignment.c b/linear-assignment.c > index 9b3e56e283..7700b80eeb 100644 > --- a/linear-assignment.c > +++ b/linear-assignment.c > @@ -51,8 +51,8 @@ void comp

[PATCH] linear-assignment: fix potential out of bounds memory access (was: Re: Git 2.19 Segmentation fault 11 on macOS)

2018-09-12 Thread Thomas Gummerer
On 09/11, Thomas Gummerer wrote: > On 09/11, Thomas Gummerer wrote: > > I think you're on the right track here. I can not test this on Mac > > OS, but on Linux, the following fails when running the test under > > valgrind: > > > > diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh > >

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Thomas Gummerer
On 09/11, Thomas Gummerer wrote: > I think you're on the right track here. I can not test this on Mac > OS, but on Linux, the following fails when running the test under > valgrind: > > diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh > index 2237c7f4af..a8b0ef8c1d 100755 >

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Junio C Hamano
Derrick Stolee writes: > On 9/11/2018 12:04 PM, Derrick Stolee wrote: > >> The patch below includes a test that fails on Mac OSX with a segfault. > ... > Sorry, nevermind. The test failed for a different reason: Even if it is for a different reason, segfaulting is not acceptable, but it seems it

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Elijah Newren
On Tue, Sep 11, 2018 at 9:07 AM ryenus wrote: > On Tue, 11 Sep 2018 at 23:49, Thomas Gummerer wrote: > > > > Hi, > > > > thanks for your bug report! > > > > On 09/11, ryenus wrote: > > > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > > > only got a Segmentation fault: 11

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Thomas Gummerer
On 09/11, Derrick Stolee wrote: > On 9/11/2018 12:04 PM, Derrick Stolee wrote: > > On 9/11/2018 11:38 AM, Derrick Stolee wrote: > > The patch below includes a test that fails on Mac OSX with a segfault. > > > > GitGitGadget PR: https://github.com/gitgitgadget/git/pull/36 > > Failed Build: > > htt

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Derrick Stolee
On 9/11/2018 12:04 PM, Derrick Stolee wrote: On 9/11/2018 11:38 AM, Derrick Stolee wrote: On 9/11/2018 11:25 AM, ryenus wrote: I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master  HEAD@{2} HEAD

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Derrick Stolee
On 9/11/2018 11:38 AM, Derrick Stolee wrote: On 9/11/2018 11:25 AM, ryenus wrote: I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master  HEAD@{2} HEAD git version 2.19.0 Segmentation fau

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread ryenus
On Tue, 11 Sep 2018 at 23:49, Thomas Gummerer wrote: > > Hi, > > thanks for your bug report! > > On 09/11, ryenus wrote: > > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > > only got a Segmentation fault: 11 > > > > $ git version; git range-diff origin/master HEAD@{2}

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Thomas Gummerer
Hi, thanks for your bug report! On 09/11, ryenus wrote: > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > only got a Segmentation fault: 11 > > $ git version; git range-diff origin/master HEAD@{2} HEAD Unfortunately the HEAD@{2} syntax needs your reflog, which is no

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Elijah Newren
On Tue, Sep 11, 2018 at 8:27 AM ryenus wrote: > > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > only got a Segmentation fault: 11 > > $ git version; git range-diff origin/master HEAD@{2} HEAD > git version 2.19.0 > Segmentation fault: 11 > > Both origin/maste

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Derrick Stolee
On 9/11/2018 11:25 AM, ryenus wrote: I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master HEAD@{2} HEAD git version 2.19.0 Segmentation fault: 11 Both origin/master and my local branch

Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread ryenus
I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master HEAD@{2} HEAD git version 2.19.0 Segmentation fault: 11 Both origin/master and my local branch each got two new commits of their own, pl