Re: Feature request: Improve diff algorithm

2018-01-30 Thread Stefan Beller
On Sat, Jan 27, 2018 at 5:08 AM, KES wrote: > One yet more: > > @@ -43,22 +44,25 @@ sub tariff_title { > 1; > > __DATA__ > -@@ control/tariff.css > -* { > -margin: 0; > -padding: 0; > -border: 0; > --webkit-box-sizing: border-box; > -box-sizing: border-box; } > -html { > -

Re: Feature request: Improve diff algorithm

2018-01-27 Thread KES
One yet more: @@ -43,22 +44,25 @@ sub tariff_title { 1; __DATA__ -@@ control/tariff.css -* { -margin: 0; -padding: 0; -border: 0; --webkit-box-sizing: border-box; -box-sizing: border-box; } -html { -background-color: #121212; -color: white; -font-family: 'Roboto

Re: Feature request: Improve diff algorithm

2018-01-26 Thread Stefan Beller
On Wed, Jan 24, 2018 at 8:43 AM, KES wrote: > Here is another place where diff can be improved: > @@ -141,8 +140,9 @@ My_runops(pTHX) > // Do not trace variables in DB:: module > if( SvOK( inDB ) ) continue; > > - sv_inc_nomg( inDB ); > > +

Re: Feature request: Improve diff algorithm

2018-01-25 Thread SZEDER Gábor
On Thu, Jan 25, 2018 at 9:12 PM, SZEDER Gábor wrote: >> One yet more: >> >> @@ -141,5 +86,9 @@ >> // } >> >> >> - OP* o; Oops, when trying to reproduce I overlooked that here the * is stuck after OP ... >> + SV *tvs = newSVpvs( "ScalarHistory" ); >> + SV *tva = newSVpvs( "Arr

Re: Feature request: Improve diff algorithm

2018-01-25 Thread Junio C Hamano
KES writes: > One yet more: > > @@ -141,5 +86,9 @@ > // } > > > - OP* o; > + SV *tvs = newSVpvs( "ScalarHistory" ); > + SV *tva = newSVpvs( "ArrayHistory" ); > + SV *tvh = newSVpvs( "HashHistory" ); > + > + OP *o; > while( PL_op ) { Huh? If the asterisk

Re: Feature request: Improve diff algorithm

2018-01-25 Thread SZEDER Gábor
> One yet more: > > @@ -141,5 +86,9 @@ > // } > > > - OP* o; > + SV *tvs = newSVpvs( "ScalarHistory" ); > + SV *tva = newSVpvs( "ArrayHistory" ); > + SV *tvh = newSVpvs( "HashHistory" ); > + > + OP *o; > while( PL_op ) { What version of Git are you using?

Re: Feature request: Improve diff algorithm

2018-01-25 Thread KES
One yet more: @@ -141,5 +86,9 @@ // } - OP* o; + SV *tvs = newSVpvs( "ScalarHistory" ); + SV *tva = newSVpvs( "ArrayHistory" ); + SV *tvh = newSVpvs( "HashHistory" ); + + OP *o; while( PL_op ) {

Re: Feature request: Improve diff algorithm

2018-01-24 Thread Jacob Keller
On Wed, Jan 24, 2018 at 8:43 AM, KES wrote: > Here is another place where diff can be improved: > @@ -141,8 +140,9 @@ My_runops(pTHX) > // Do not trace variables in DB:: module > if( SvOK( inDB ) ) continue; > > - sv_inc_nomg( inDB ); > > +

Re: Feature request: Improve diff algorithm

2018-01-24 Thread KES
Here is another place where diff can be improved: @@ -141,8 +140,9 @@ My_runops(pTHX) // Do not trace variables in DB:: module if( SvOK( inDB ) ) continue; - sv_inc_nomg( inDB ); + // save_item( inDB ); + sv_inc_nomg( inD

Re: Feature request: Improve diff algorithm

2016-11-21 Thread Jacob Keller
On Mon, Nov 21, 2016 at 10:17 AM, Stefan Beller wrote: > On Mon, Nov 21, 2016 at 8:56 AM, Jacob Keller wrote: >> On Mon, Nov 21, 2016 at 12:11 AM, KES wrote: >>> Hi. >>> >> >> Hi, >> >>> I have some question about how diff works then give proposal: >>> >>> it will be very useful for each "symbol

Re: Feature request: Improve diff algorithm

2016-11-21 Thread Stefan Beller
On Mon, Nov 21, 2016 at 8:56 AM, Jacob Keller wrote: > On Mon, Nov 21, 2016 at 12:11 AM, KES wrote: >> Hi. >> > > Hi, > >> I have some question about how diff works then give proposal: >> >> it will be very useful for each "symbol" store additional meta info as >> source line length. So in this

Re: Feature request: Improve diff algorithm

2016-11-21 Thread Jacob Keller
On Mon, Nov 21, 2016 at 12:11 AM, KES wrote: > Hi. > Hi, > I have some question about how diff works then give proposal: > > it will be very useful for each "symbol" store additional meta info as source > line length. So in this case when git counter two equal sequence of commands > it will do

Feature request: Improve diff algorithm

2016-11-21 Thread KES
Hi. I have some question about how diff works then give proposal: it will be very useful for each "symbol" store additional meta info as source line length. So in this case when git counter two equal sequence of commands it will do further comparison: Adds 23 chars deletes none VS adds 75 chars