Re: Feature request: Allow to update commit ID in messages when rebasing

2019-04-19 Thread Jakub Narebski
Hello, Giuseppe Crinò writes: > On Thu, Apr 18, 2019 at 7:32 PM Jakub Narebski wrote: >> Well, what about limiting changes and rewriting only to the commits >> being rewritten by [interactive] rebase? I mean that we would rewrite >> "revert 01a9fe8" only if: >> >> a.) the commit with this mess

Re: Feature request: Allow to update commit ID in messages when rebasing

2019-04-18 Thread Giuseppe Crinò
On Thu, Apr 18, 2019 at 7:32 PM Jakub Narebski wrote: > Well, what about limiting changes and rewriting only to the commits > being rewritten by [interactive] rebase? I mean that we would rewrite > "revert 01a9fe8" only if: > > a.) the commit with this message is undergoing rewrite > b.) the comm

Re: Feature request: Allow to update commit ID in messages when rebasing

2019-04-18 Thread Phil Hord
Wouldn't we need to extend this to cherry-pick, too? Suppose I do this: $ git log -2 --oneline --decorate foo abcd123456 (foo) Revert 123456 123456 Some useful commit for the future, but not now $ git checkout bar $ git cherry-pick foo^ foo $ git log -2 --one

Re: Feature request: Allow to update commit ID in messages when rebasing

2019-04-18 Thread Jakub Narebski
Junio C Hamano writes: > Ævar Arnfjörð Bjarmason writes: >> On Wed, Apr 17 2019, Giuseppe Crinò wrote: >> >>> The feature I'm asking is to add an extra-step during rebasing, >>> checking whether there's a reference to a commit that's not going to >>> be included in history and asks the user wheth

Re: Feature request: Allow to update commit ID in messages when rebasing

2019-04-17 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Wed, Apr 17 2019, Giuseppe Crinò wrote: > >> The feature I'm asking is to add an extra-step during rebasing, >> checking whether there's a reference to a commit that's not going to >> be included in history and asks the user whether the heuristics is >> correc

Re: Feature request: Allow to update commit ID in messages when rebasing

2019-04-17 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 17 2019, Giuseppe Crinò wrote: > The feature I'm asking is to add an extra-step during rebasing, > checking whether there's a reference to a commit that's not going to > be included in history and asks the user whether the heuristics is > correct and if she wants to update those refe

Feature request: Allow to update commit ID in messages when rebasing

2019-04-17 Thread Giuseppe Crinò
The feature I'm asking is to add an extra-step during rebasing, checking whether there's a reference to a commit that's not going to be included in history and asks the user whether the heuristics is correct and if she wants to update those references. Scenario: it can happen for a commit message