Re: Deprecating git diff ..; dealing with other ranges

2019-03-18 Thread Elijah Newren
On Mon, Mar 18, 2019 at 10:11 AM Michal Suchánek wrote: > > On Mon, 18 Mar 2019 10:07:08 -0700 > Elijah Newren wrote: > > > On Tue, Mar 12, 2019 at 2:01 PM Ævar Arnfjörð Bjarmason > > wrote: > > > On Tue, Mar 12 2019, Andreas Schwab wrote: > > > > On Mär 12 2019, Junio C Hamano wrote: > > > > >

Re: Deprecating git diff ..; dealing with other ranges

2019-03-18 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 18 2019, Elijah Newren wrote: > On Tue, Mar 12, 2019 at 2:01 PM Ævar Arnfjörð Bjarmason > wrote: >> On Tue, Mar 12 2019, Andreas Schwab wrote: >> > On Mär 12 2019, Junio C Hamano wrote: >> > >> >> I however think it may be worth making sure that our docs do not >> >> encourage "dif

Re: Deprecating git diff ..; dealing with other ranges

2019-03-18 Thread Michal Suchánek
On Mon, 18 Mar 2019 10:07:08 -0700 Elijah Newren wrote: > On Tue, Mar 12, 2019 at 2:01 PM Ævar Arnfjörð Bjarmason > wrote: > > On Tue, Mar 12 2019, Andreas Schwab wrote: > > > On Mär 12 2019, Junio C Hamano wrote: > > > > > >> I however think it may be worth making sure that our docs do not

Re: Deprecating git diff ..; dealing with other ranges

2019-03-18 Thread Elijah Newren
On Tue, Mar 12, 2019 at 2:01 PM Ævar Arnfjörð Bjarmason wrote: > On Tue, Mar 12 2019, Andreas Schwab wrote: > > On Mär 12 2019, Junio C Hamano wrote: > > > >> I however think it may be worth making sure that our docs do not > >> encourage "diff A..B" and teach "diff A B" when comparing two > >> e

Re: Deprecating git diff ..; dealing with other ranges

2019-03-13 Thread Andreas Schwab
On Mär 13 2019, Duy Nguyen wrote: > A..B from fetch is the same as branch@{1}..branch. If we have some > shortcut similar to ^! but for reflog, that would be perfect (the > branch part does not require much typing with tab completion). Tab completion is much slower than c&p, especially if the co

Re: Deprecating git diff ..; dealing with other ranges

2019-03-13 Thread Johannes Sixt
Am 12.03.19 um 22:01 schrieb Ævar Arnfjörð Bjarmason: > > On Tue, Mar 12 2019, Andreas Schwab wrote: > >> On Mär 12 2019, Junio C Hamano wrote: >> >>> I however think it may be worth making sure that our docs do not >>> encourage "diff A..B" and teach "diff A B" when comparing two >>> endpoints.

Re: Deprecating git diff ..; dealing with other ranges

2019-03-12 Thread Duy Nguyen
On Wed, Mar 13, 2019 at 12:26 AM Andreas Schwab wrote: > > On Mär 12 2019, Junio C Hamano wrote: > > > I however think it may be worth making sure that our docs do not > > encourage "diff A..B" and teach "diff A B" when comparing two > > endpoints. That can be done without changing anything in t

Re: Deprecating git diff ..; dealing with other ranges

2019-03-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Mar 12 2019, Andreas Schwab wrote: > On Mär 12 2019, Junio C Hamano wrote: > >> I however think it may be worth making sure that our docs do not >> encourage "diff A..B" and teach "diff A B" when comparing two >> endpoints. That can be done without changing anything in the code. > > Th

Re: Deprecating git diff ..; dealing with other ranges

2019-03-12 Thread Andreas Schwab
On Mär 12 2019, Junio C Hamano wrote: > I however think it may be worth making sure that our docs do not > encourage "diff A..B" and teach "diff A B" when comparing two > endpoints. That can be done without changing anything in the code. The nice thing about "diff A..B" is that you can c&p the

Re: Deprecating git diff ..; dealing with other ranges

2019-03-12 Thread Junio C Hamano
Denton Liu writes: > =>content="$(git diff HEAD^! | tail -n 1)" > ... > It gets caught in my attempt to only deprecate ..'s. Technically, it's > undocumented behaviour and it only happens to work because git-diff > accept ranges but it doesn't operate in an intuitive way. It reuses t

Re: Deprecating git diff ..; dealing with other ranges

2019-03-12 Thread Junio C Hamano
Denton Liu writes: > I was in the process of deprecating `git diff ..` as > discussed here[1]. > > [1]: https://public-inbox.org/git/xmqqmumy6mxe@gitster-ct.c.googlers.com/ I didn't (and don't) advocate such a deprecation, FWIW, in that message. I simply do not think it is worth the cost.

Re: Deprecating git diff ..; dealing with other ranges

2019-03-11 Thread Elijah Newren
Hi, On Mon, Mar 11, 2019 at 2:37 AM Denton Liu wrote: > > Hello all, > > I was in the process of deprecating `git diff ..` as > discussed here[1]. However, I ran into a weird case that I'm not sure > how to deal with. > > In t3430-rebase-merges.sh:382, we have the following test case which > invo

Re: Deprecating git diff ..; dealing with other ranges

2019-03-11 Thread Johannes Schindelin
Hi Denton, On Mon, 11 Mar 2019, Denton Liu wrote: > I was in the process of deprecating `git diff ..` as > discussed here[1]. However, I ran into a weird case that I'm not sure > how to deal with. > > In t3430-rebase-merges.sh:382, we have the following test case which > invokes git diff: > >

Deprecating git diff ..; dealing with other ranges

2019-03-11 Thread Denton Liu
Hello all, I was in the process of deprecating `git diff ..` as discussed here[1]. However, I ran into a weird case that I'm not sure how to deal with. In t3430-rebase-merges.sh:382, we have the following test case which invokes git diff: test_expect_success 'with --autosquash and --exec