Re: Corner case bug caused by shell dependent behavior

2014-03-14 Thread Uwe Storbeck
On Mar 13, Jonathan Nieder wrote: > May we have your sign-off? (See Documentation/SubmittingPatches > section "Sign your work" for what this means. I could have found that myself .. thanks! I'll try to follow it now. :) I'll resend the patch. Hopefully I'll do it right. > Would it make sense to

Re: Corner case bug caused by shell dependent behavior

2014-03-13 Thread David Kastrup
Jeff King writes: > Hmph. We ran into this before and fixed all of the sites (e.g., d1c3b10 > and 938791c). This one appears to have been added a few months later > (by 68d5d03). > >> Maybe there are more places where it would be more robust to use >> printf instead of echo. > > FWIW, I just look

Re: Corner case bug caused by shell dependent behavior

2014-03-13 Thread Jeff King
On Fri, Mar 14, 2014 at 01:02:13AM +0100, Uwe Storbeck wrote: > When your system shell (/bin/sh) is a dash control sequences in > strings get interpreted by the echo command. A commit message > which ends with the string '\n' may result in a garbage line in > the todo list of an interactive rebase

Re: Corner case bug caused by shell dependent behavior

2014-03-13 Thread Jonathan Nieder
Hi, Uwe Storbeck wrote: > To reproduce the behavior (with dash as /bin/sh): > > mkdir test && cd test && git init > echo 1 >foo && git add foo > git commit -m"this commit message ends with '\n'" > echo 2 >foo && git commit -a --fixup HEAD > git rebase -i --autosquash --root > > Now the

Corner case bug caused by shell dependent behavior

2014-03-13 Thread Uwe Storbeck
Hi When your system shell (/bin/sh) is a dash control sequences in strings get interpreted by the echo command. A commit message which ends with the string '\n' may result in a garbage line in the todo list of an interactive rebase which causes the rebase to fail. To reproduce the behavior (with