W. Trevor King wrote:
> The indentation for the closing parenthesis is optional [2]. You can
> of course do things like:
>
> from mercurial import (
> bar, baz,
> foo,
> )
I prefer:
from mercurial foo, bar, ...
from mercurial baz, ...
--
Felipe Contreras
--
To unsubscr
On Fri, May 09, 2014 at 02:44:02AM -0500, William Giokas wrote:
> Maybe a time to use something like::
>
> from mercurial import foo \
> bar \
> baz \
> ...
>
> Would make that import into quite a few lines, but would help
On 05/09/2014 04:09 AM, Jonathan Nieder wrote:
> (cc-ing Pete Wyckoff who maintains git-p4 and Michael Haggerty
> who maintains git-multimail)
> William Giokas wrote:
>
>> - We follow PEP-8 (http://www.python.org/dev/peps/pep-0008/).
>>
>> It's even the first thing that you see when you go lo
On Thu, May 08, 2014 at 08:54:29PM -0500, William Giokas wrote:
> So I have been looking into the python code in the git tree recently
> (contrib and core tree) and noticed that almost none of the files fully
> conform to pep8. Now I'm not just saying this because I like the code to
> be clean, rea
On Fri, May 09, 2014 at 02:35:34AM -0500, Felipe Contreras wrote:
> William Giokas wrote:
> > Yeah. In fact, for the mercurial stuff the `from mercurial import
> > changegroup`
> > line should be on the same line as the other `from mercurial import ...`
> > line.
>
> I think the line is too big,
William Giokas wrote:
> On Fri, May 09, 2014 at 02:18:54AM -0500, Felipe Contreras wrote:
> > William Giokas wrote:
> > > On Thu, May 08, 2014 at 11:36:29PM -0500, Felipe Contreras wrote:
> > > > William Giokas wrote:
> > > > > E401: Multi-line imports seems like something that would just be
> > >
On Fri, May 09, 2014 at 02:18:54AM -0500, Felipe Contreras wrote:
> William Giokas wrote:
> > On Thu, May 08, 2014 at 11:36:29PM -0500, Felipe Contreras wrote:
> > > William Giokas wrote:
> > > > E401: Multi-line imports seems like something that would just be
> > > > changing one line
> > >
> > >
William Giokas wrote:
> On Thu, May 08, 2014 at 11:36:29PM -0500, Felipe Contreras wrote:
> > William Giokas wrote:
> > > E401: Multi-line imports seems like something that would just be
> > > changing one line
> >
> > Yes, and make the code very annoying.
>
> It's 1 extra line in git-remote-hg,
On Thu, May 08, 2014 at 11:36:29PM -0500, Felipe Contreras wrote:
> William Giokas wrote:
> > E401: Multi-line imports seems like something that would just be
> > changing one line
>
> Yes, and make the code very annoying.
It's 1 extra line in git-remote-hg, and 4 lines in git-remote-bzr. I'll
ev
William Giokas wrote:
> On Thu, May 08, 2014 at 09:10:25PM -0500, Felipe Contreras wrote:
> > William Giokas wrote:
> > > Which is a whole bunch of errors and warnings thrown by pep8. Is pep8
> > > just getting put by the wayside? I would much rather have these
> > > scripts conform to that and hav
On Thu, May 08, 2014 at 09:10:25PM -0500, Felipe Contreras wrote:
> William Giokas wrote:
> > Which is a whole bunch of errors and warnings thrown by pep8. Is pep8
> > just getting put by the wayside? I would much rather have these
> > scripts conform to that and have an actual coding style rather
William Giokas wrote:
> Which is a whole bunch of errors and warnings thrown by pep8. Is pep8
> just getting put by the wayside? I would much rather have these
> scripts conform to that and have an actual coding style rather than
> just be a hodge-podge of different styles.
Personally I try to fol
(cc-ing Pete Wyckoff who maintains git-p4 and Michael Haggerty
who maintains git-multimail)
Hi,
William Giokas wrote:
> - We follow PEP-8 (http://www.python.org/dev/peps/pep-0008/).
>
> It's even the first thing that you see when you go looking for 'python'
> in the coding style document. I
Hi all,
So I have been looking into the python code in the git tree recently
(contrib and core tree) and noticed that almost none of the files fully
conform to pep8. Now I'm not just saying this because I like the code to
be clean, readable and easily parsed by humans, but also because this is
lai
14 matches
Mail list logo
