Re: [PATCH] worktree: don't use C99 feature

2015-09-23 Thread Junio C Hamano
Ramsay Jones writes: > Commits 9c0b9f6 ("worktree: add 'list' command", 18-09-2015) and > 40ca3d3 ("worktree: add functions to get worktree details", 18-08-2015) > both introduce the use of a C99 feature (declare the loop control > variable in the loop h

[PATCH] worktree: don't use C99 feature

2015-09-23 Thread Ramsay Jones
Commits 9c0b9f6 ("worktree: add 'list' command", 18-09-2015) and 40ca3d3 ("worktree: add functions to get worktree details", 18-08-2015) both introduce the use of a C99 feature (declare the loop control variable in the loop header initializer section). Signed-off-b

Re: C99

2015-04-04 Thread brian m. carlson
On Sat, Apr 04, 2015 at 01:06:43PM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > > So it isn't as much of a "we don't want to move to C99" as much as "we > > aren't yet willing to drop support for older versions of MSVC&qu

Re: C99

2015-04-04 Thread Junio C Hamano
"brian m. carlson" writes: > So it isn't as much of a "we don't want to move to C99" as much as "we > aren't yet willing to drop support for older versions of MSVC". I do not particularly like that 'we' in that sentence, which would

C99 (Was: Re: Freeing struct lock_file?)

2015-04-04 Thread brian m. carlson
On Fri, Apr 03, 2015 at 08:24:43PM -0400, David Turner wrote: > But I can see why git wouldn't want to depend on that behavior. C11 has > a way to do this safely, but AIUI, git doesn't want to move to C99 let > alone C11. So I guess this will just have to remain the way it