On Fri, Jan 05, 2018 at 02:37:25PM -0800, Junio C Hamano wrote:
> Well, MaintNotes on the 'todo' branch needs a bit of updating, as it
> says something somewhat misleading.
>
> -- >8 --
> Subject: MaintNotes: clarify the purpose of maint->master upmerge
Yup, this makes sense. Thanks for clarifyi
Jeff King writes:
> On Fri, Jan 05, 2018 at 12:45:03PM -0800, Junio C Hamano wrote:
>
>> Jeff King writes:
>>
>> > Out of curiosity, did this change at some point? I thought the process
>> > used to be to merge to maint, and then pick up topics in master by
>> > merging maint to master.
>>
>>
Hi Peff,
On Fri, 5 Jan 2018, Jeff King wrote:
> On Fri, Jan 05, 2018 at 09:22:07PM +0100, Johannes Schindelin wrote:
>
> > On Fri, 5 Jan 2018, Isaac Shabtay wrote:
> >
> > > Done: https://github.com/git-for-windows/git/pull/1421
> > >
> > > I added credit to Jeff in the PR's description.
> >
Hi,
On Fri, 5 Jan 2018, Junio C Hamano wrote:
> Jeff King writes:
>
> > On Wed, Jan 03, 2018 at 02:42:51PM -0800, Isaac Shabtay wrote:
> >
> >> Indeed interesting... this one's for the books...
> >> Thanks for the patches. Any idea when these are going to make it to the
> >> official Git clien
On Fri, Jan 05, 2018 at 12:45:03PM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > Out of curiosity, did this change at some point? I thought the process
> > used to be to merge to maint, and then pick up topics in master by
> > merging maint to master.
>
> If you look at "Sync with main
Jeff King writes:
> Out of curiosity, did this change at some point? I thought the process
> used to be to merge to maint, and then pick up topics in master by
> merging maint to master.
If you look at "Sync with maint" merges made to 'master', you'd
notice that most of them are only updating Do
On Fri, Jan 05, 2018 at 09:22:07PM +0100, Johannes Schindelin wrote:
> On Fri, 5 Jan 2018, Isaac Shabtay wrote:
>
> > Done: https://github.com/git-for-windows/git/pull/1421
> >
> > I added credit to Jeff in the PR's description.
>
> Sadly, the PR's description won't make it into the commit hist
Johannes Schindelin writes:
> Hi Isaac,
>
> On Fri, 5 Jan 2018, Isaac Shabtay wrote:
>
>> Done: https://github.com/git-for-windows/git/pull/1421
>>
>> I added credit to Jeff in the PR's description.
>
> Sadly, the PR's description won't make it into the commit history, and the
> authorship reall
Hi Isaac,
On Fri, 5 Jan 2018, Isaac Shabtay wrote:
> Done: https://github.com/git-for-windows/git/pull/1421
>
> I added credit to Jeff in the PR's description.
Sadly, the PR's description won't make it into the commit history, and the
authorship really should have been retained.
I found Peff's
On Fri, Jan 05, 2018 at 11:53:50AM -0800, Junio C Hamano wrote:
> > They haven't even been reviewed yet. If they get good feedback, then the
> > maintainer will pick them up, then merge them to 'next', and then
> > eventually to 'master', after which they'd become part of the next
> > major releas
Jeff King writes:
> On Wed, Jan 03, 2018 at 02:42:51PM -0800, Isaac Shabtay wrote:
>
>> Indeed interesting... this one's for the books...
>> Thanks for the patches. Any idea when these are going to make it to the
>> official Git client builds? (specifically the Windows one)
>
> They haven't even
Done: https://github.com/git-for-windows/git/pull/1421
I added credit to Jeff in the PR's description.
Note that I tried compiling master, but failed due to a reason
unrelated to this patch:
builtin/checkout.c:24:10: fatal error: fscache.h: No such file or directory
Maybe I wasn't building it r
Hi Isaac,
On Thu, 4 Jan 2018, Isaac Shabtay wrote:
> I cloned git's codebase, applied the four patches on master, built and
> tested on Ubuntu Trusty. (After verifying that master indeed exhibits
> this behaviour on Linux as well. Just checking).
> Seems to work fine.
> I also looked at the code.
Hello Johannes, Jeff,
I cloned git's codebase, applied the four patches on master, built and
tested on Ubuntu Trusty. (After verifying that master indeed exhibits
this behaviour on Linux as well. Just checking).
Seems to work fine.
I also looked at the code. Most of the patched lines relate to tes
Hi Isaac,
On Wed, 3 Jan 2018, Isaac Shabtay wrote:
> Indeed interesting... this one's for the books...
> Thanks for the patches. Any idea when these are going to make it to
> the official Git client builds? (specifically the Windows one)
If you help them getting reviewed, tested, and validated,
On Wed, Jan 03, 2018 at 02:42:51PM -0800, Isaac Shabtay wrote:
> Indeed interesting... this one's for the books...
> Thanks for the patches. Any idea when these are going to make it to the
> official Git client builds? (specifically the Windows one)
They haven't even been reviewed yet. If they ge
Indeed interesting... this one's for the books...
Thanks for the patches. Any idea when these are going to make it to
the official Git client builds? (specifically the Windows one)
On 3 January 2018 at 14:28, Jeff King wrote:
> On Wed, Jan 03, 2018 at 12:59:48PM -0800, Isaac Shabtay wrote:
>
>> T
On Wed, Jan 03, 2018 at 12:59:48PM -0800, Isaac Shabtay wrote:
> Target directory is deleted on clone failures.
>
> Steps to reproduce, for example on Windows:
>
> cd /d %TEMP%
> mkdir dest
> git clone https://some-fake-url/whatever-makes-git-clone-fail dest
>
> Of course, the clone will fail a
Hello,
Target directory is deleted on clone failures.
Steps to reproduce, for example on Windows:
cd /d %TEMP%
mkdir dest
git clone https://some-fake-url/whatever-makes-git-clone-fail dest
Of course, the clone will fail as it should. But looks like the Git
client also ends up deleting the "dest"
19 matches
Mail list logo
