Re: Bug report: Duplicate CRLF rewrite warnings on commit

2016-05-14 Thread Adam Dinwoodie
On Sat, May 14, 2016 at 07:40:11AM +0200, Torsten Bögershausen wrote: > On 13.05.16 18:43, Junio C Hamano wrote: > > Adam Dinwoodie writes: > > > >> If you use .gitattributes to enable CRLF->LF rewriting, then commit a > >> file that would have its line endings rewritten, the "CRLF will be > >> r

Re: Bug report: Duplicate CRLF rewrite warnings on commit

2016-05-13 Thread Torsten Bögershausen
On 13.05.16 18:43, Junio C Hamano wrote: > Adam Dinwoodie writes: > >> If you use .gitattributes to enable CRLF->LF rewriting, then commit a >> file that would have its line endings rewritten, the "CRLF will be >> replaced by LF" warning is printed several times over; I'd expect it to >> be print

Re: Bug report: Duplicate CRLF rewrite warnings on commit

2016-05-13 Thread Jeff King
On Fri, May 13, 2016 at 12:46:57PM -0700, Junio C Hamano wrote: > > We don't want commits that fail the test suite, since it makes bisection > > more difficult. But you can mark known bugs like: > > > >test_expect_failure 'git-foo should output bar' ' > > ... > >' > > > > I think it's

Re: Bug report: Duplicate CRLF rewrite warnings on commit

2016-05-13 Thread Junio C Hamano
Jeff King writes: > On Fri, May 13, 2016 at 02:49:53PM +0100, Adam Dinwoodie wrote: > >> (Tangentially: what's the accepted practice for submitting failing test >> scripts? I've written a short test case to add to t0020 that shows this >> bugged behaviour, but I've got the vague impression from

Re: Bug report: Duplicate CRLF rewrite warnings on commit

2016-05-13 Thread Jeff King
On Fri, May 13, 2016 at 02:49:53PM +0100, Adam Dinwoodie wrote: > (Tangentially: what's the accepted practice for submitting failing test > scripts? I've written a short test case to add to t0020 that shows this > bugged behaviour, but I've got the vague impression from past emails > that leading

Re: Bug report: Duplicate CRLF rewrite warnings on commit

2016-05-13 Thread Junio C Hamano
Adam Dinwoodie writes: > If you use .gitattributes to enable CRLF->LF rewriting, then commit a > file that would have its line endings rewritten, the "CRLF will be > replaced by LF" warning is printed several times over; I'd expect it to > be printed only once. > > There's a test case in t0020 --

Bug report: Duplicate CRLF rewrite warnings on commit

2016-05-13 Thread Adam Dinwoodie
If you use .gitattributes to enable CRLF->LF rewriting, then commit a file that would have its line endings rewritten, the "CRLF will be replaced by LF" warning is printed several times over; I'd expect it to be printed only once. There's a test case in t0020 -- "safecrlf: print warning only once"