Re: Bug: `git commit --fixup` with duplicate commit messages

2018-12-14 Thread John Passaro
On Fri, 14 Dec 2018, Oliver Joseph Ash wrote: > I believe I have found a bug in `git commit --fixup`. > > Steps to reproduce: > 1. Create a git history with two commits (A and B) with the same > commit message (e.g. foo) > 2. Create a new commit using `git commit --fixup {SHA}`, referring to > th

Re: Bug: `git commit --fixup` with duplicate commit messages

2018-12-14 Thread Rafael Ascensão
On Fri, Dec 14, 2018 at 12:30:28PM +, Oliver Joseph Ash wrote: > I believe I have found a bug in `git commit --fixup`. That's not a bug, it's actually the documented behaviour of rebase --autosquash. As you figured out, the squash/fixup is based on whether the message has the squash!/fixup! p

Re: Bug: `git commit --fixup` with duplicate commit messages

2018-12-14 Thread Johannes Schindelin
Hi Oliver, On Fri, 14 Dec 2018, Oliver Joseph Ash wrote: > I believe I have found a bug in `git commit --fixup`. > > Steps to reproduce: > 1. Create a git history with two commits (A and B) with the same > commit message (e.g. foo) > 2. Create a new commit using `git commit --fixup {SHA}`, refer

Bug: `git commit --fixup` with duplicate commit messages

2018-12-14 Thread Oliver Joseph Ash
Hi, I believe I have found a bug in `git commit --fixup`. Steps to reproduce: 1. Create a git history with two commits (A and B) with the same commit message (e.g. foo) 2. Create a new commit using `git commit --fixup {SHA}`, referring to the last commit SHA 3. Run an interactive rebase Expected