Re: Bug/request: the empty string should be a valid git note

2014-09-22 Thread Junio C Hamano
"Kyle J. McKay" writes: > On Sep 20, 2014, at 18:44, Johan Herland wrote: > >> At least, we should fix >> >>git notes add -C e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 >> >> Whether we should also change >> >>git notes add -m '' >> >> to create an empty note, or leave it as-is, (i.e. simila

Re: Bug/request: the empty string should be a valid git note

2014-09-21 Thread Kyle J. McKay
On Sep 20, 2014, at 18:44, Johan Herland wrote: At least, we should fix git notes add -C e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 Whether we should also change git notes add -m '' to create an empty note, or leave it as-is, (i.e. similar in spirit to "git commit -m ''"), I'll leave up

Re: Bug/request: the empty string should be a valid git note

2014-09-20 Thread Johan Herland
On Sat, Sep 20, 2014 at 9:47 PM, James H. Fisher wrote: > In the documentation for git notes [1] I read: > > In principle, a note is a regular Git blob, and any kind of > (non-)format is accepted. > > Then, since the empty string is a valid regular Git blob, the empty > string is also a va

Re: Bug/request: the empty string should be a valid git note

2014-09-20 Thread James H. Fisher
Apologies for re-sending; unclear whether my email was delivered since I sent it before my subscription was confirmed. On 20 Sep 2014, at 20:47, James H. Fisher wrote: > In the documentation for git notes [1] I read: > >In principle, a note is a regular Git blob, and any kind of (non-)form

Bug/request: the empty string should be a valid git note

2014-09-20 Thread James H. Fisher
In the documentation for git notes [1] I read: In principle, a note is a regular Git blob, and any kind of (non-)format is accepted. Then, since the empty string is a valid regular Git blob, the empty string is also a valid git note. Therefore this behavior was unexpected for me: > gi