Re: Wrong -dirty suffix set by setlocalversion (was: BUG in git diff-index)

2018-05-24 Thread Marc Herbert
On 24/05/2018 16:03, Mike Mason wrote: > diff --git a/scripts/setlocalversion b/scripts/setlocalversion > index 71f39410691b..9da4c5e83285 100755 > --- a/scripts/setlocalversion > +++ b/scripts/setlocalversion > @@ -73,8 +73,10 @@ scm_version() > printf -- '-svn%s' "`git svn

Re: Wrong -dirty suffix set by setlocalversion (was: BUG in git diff-index)

2018-05-24 Thread Mike Mason
How about something like this? It ignores attributes that should have no bearing on whether the kernel is considered dirty. Copied trees with no other changes would no longer be marked with -dirty. Plus it works on read-only media since no index updating is required. Would this also be considered

Wrong -dirty suffix set by setlocalversion (was: BUG in git diff-index)

2017-09-27 Thread Marc Herbert
+ linux-kbuild list which is not in the output of: ./scripts/get_maintainer.pl -f scripts/setlocalversion ... but seems relevant anyway. On 31/03/16 13:39, Junio C Hamano wrote: > Andy Lowry writes: > >> So I think now that the script should do "update-index --refresh" >> followed by "diff-in

Google indexing https://public-inbox.org/git (was: BUG in git diff-index)

2017-09-26 Thread Marc Herbert
[Reduced Cc: and change Subject:] On 26/09/17 13:11, Eric Wong wrote: > There's no blocks on public-inbox.org and I'm completely against > any sort of blocking/throttling. Maybe there's too many pages > to index? Or the Message-IDs in URLs are too ugly/scary? Not > sure what to do about that...

Re: BUG in git diff-index

2017-09-26 Thread Eric Wong
Marc Herbert wrote: > PS: I used NNTP and http://dir.gmane.org/gmane.comp.version-control.git > to quickly find this old thread (what could we do without NNTP?). Then > I googled for a web archive of this thread and Google could only find > this one: > http://git.661346.n2.nabble

Re: BUG in git diff-index

2017-09-26 Thread Marc Herbert
way) PS: I used NNTP and http://dir.gmane.org/gmane.comp.version-control.git to quickly find this old thread (what could we do without NNTP?). Then I googled for a web archive of this thread and Google could only find this one: http://git.661346.n2.nabble.com/BUG-in-git-diff-index-tt

Re: BUG in git diff-index

2016-03-31 Thread Junio C Hamano
Andy Lowry writes: > So I think now that the script should do "update-index --refresh" > followed by "diff-index --quiet HEAD". Sound correct? Yes. That has always been one of the kosher ways for any script to make sure that the files in the working tree that are tracked have not been modified

Re: BUG in git diff-index

2016-03-31 Thread Andy Lowry
OK, great. I think the update-index command is what I need. If you'll indulge me, I'll describe my use-case in detail, and if you see anything screwy about it, I'd appreciate feedback. But don't feel obligated - you've been a great help already. This is all about publishing updates to a stati

Re: BUG in git diff-index

2016-03-31 Thread Jeff King
On Thu, Mar 31, 2016 at 10:12:07AM -0400, Andy Lowry wrote: > What I'm actually after is a tree-to-filesystem comparison, regardless > of index. I've currently got a "diff" thrown in as a "work-around" > before "diff-index", but now I understand it's not a workaround at > all. If there's a better

BUG in git diff-index

2016-03-31 Thread Andy Lowry
Thanks, very helpful. What I'm actually after is a tree-to-filesystem comparison, regardless of index. I've currently got a "diff" thrown in as a "work-around" before "diff-index", but now I understand it's not a workaround at all. If there's a better way to achieve what I'm after, I'd appreciate

Re: BUG in git diff-index

2016-03-31 Thread Jeff King
On Thu, Mar 31, 2016 at 12:39:23PM +, Andy Lowry wrote: > Following transcript illustrates what I believe to be a bug in git diff- > index. The session used a git built from latest source, located in > /tmp/git/git. > > 1. New repo, create empty file A, commit changes. > 2

Re: BUG in git diff-index

2016-03-31 Thread Carlos Martín Nieto
On Thu, 2016-03-31 at 12:39 +, Andy Lowry wrote: > Following transcript illustrates what I believe to be a bug in git > diff- > index. The session used a git built from latest source, located in  > /tmp/git/git. > > 1. New repo, create empty file A, commit changes. > 2.

BUG in git diff-index

2016-03-31 Thread Andy Lowry
Following transcript illustrates what I believe to be a bug in git diff- index. The session used a git built from latest source, located in /tmp/git/git. 1. New repo, create empty file A, commit changes. 2. touch A 3. git diff-index reports A has changed, and reports bogus destination SHA 4