Re: A rebase regression in Git 2.18.0

2018-08-31 Thread Elijah Newren
Hi Dscho, On Fri, Aug 31, 2018 at 3:12 AM Johannes Schindelin wrote: > On Thu, 30 Aug 2018, Elijah Newren wrote: > > On Tue, Aug 28, 2018 at 9:58 AM Junio C Hamano wrote: > > > Elijah Newren writes: ... > > > I'd say this is the only practical solution, before you deprecate > > > the "pipe form

Re: A rebase regression in Git 2.18.0

2018-08-31 Thread Johannes Schindelin
Hi Elijah, On Thu, 30 Aug 2018, Elijah Newren wrote: > On Tue, Aug 28, 2018 at 9:58 AM Junio C Hamano wrote: > > > > Elijah Newren writes: > > > > > - Add a flag to turn off directory rename detection, and set the > > > flag for every call from am.c in order to avoid problems like this. > > >

Re: A rebase regression in Git 2.18.0

2018-08-30 Thread Elijah Newren
On Tue, Aug 28, 2018 at 9:58 AM Junio C Hamano wrote: > > Elijah Newren writes: > > > - Add a flag to turn off directory rename detection, and set the > > flag for every call from am.c in order to avoid problems like this. > > I'd say this is the only practical solution, before you deprecate >

Re: A rebase regression in Git 2.18.0

2018-08-28 Thread Junio C Hamano
Elijah Newren writes: > - Add a flag to turn off directory rename detection, and set the > flag for every call from am.c in order to avoid problems like this. I'd say this is the only practical solution, before you deprecate the "pipe format-patch output to am -3" style of "git rebase" (and op

Re: A rebase regression in Git 2.18.0

2018-08-28 Thread Elijah Newren
On Tue, Aug 28, 2018 at 6:33 AM Johannes Schindelin wrote: > On Tue, 28 Aug 2018, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Aug 28 2018, Nikolay Kasyanov wrote: > > > > > I’ve found something that may be a regression in git rebase > > > implementation in 2.18.0. > > > First I spotted it on macOS

Re: A rebase regression in Git 2.18.0

2018-08-28 Thread Nikolay Kasyanov
Hi, Yes, it does fix this behavior. Could you please point me to the thread? Best, Nikolay > On 28. Aug 2018, at 15:33, Johannes Schindelin > wrote: > > Hi, > > On Tue, 28 Aug 2018, Ævar Arnfjörð Bjarmason wrote: > >> On Tue, Aug 28 2018, Nikolay Kasyanov wrote: >> >>> I’ve found something

Re: A rebase regression in Git 2.18.0

2018-08-28 Thread Johannes Schindelin
Hi, On Tue, 28 Aug 2018, Ævar Arnfjörð Bjarmason wrote: > On Tue, Aug 28 2018, Nikolay Kasyanov wrote: > > > I’ve found something that may be a regression in git rebase implementation > > in 2.18.0. > > First I spotted it on macOS but I can also confirm it happening on Linux. > > Git 2.19.0.rc0

Re: A rebase regression in Git 2.18.0

2018-08-28 Thread Ævar Arnfjörð Bjarmason
On Tue, Aug 28 2018, Nikolay Kasyanov wrote: > Hi, > > I’ve found something that may be a regression in git rebase implementation in > 2.18.0. > First I spotted it on macOS but I can also confirm it happening on Linux. > Git 2.19.0.rc0.48.gb9dfa238d is affected too. > > In order to trigger it,

A rebase regression in Git 2.18.0

2018-08-28 Thread Nikolay Kasyanov
Hi, I’ve found something that may be a regression in git rebase implementation in 2.18.0. First I spotted it on macOS but I can also confirm it happening on Linux. Git 2.19.0.rc0.48.gb9dfa238d is affected too. In order to trigger it, a repo layout similar to the following is required: files/