Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Junio C Hamano
Jeff King writes: > On Thu, Sep 13, 2012 at 12:40:39PM -0700, Junio C Hamano wrote: > >> > Interesting. I don't get any such warning on repack. And RelNotes points >> > to a file, so I'm not sure why stat() would make us think it was a dir. >> >> Interesting. The command in question is >> >>

Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Jeff King
On Thu, Sep 13, 2012 at 12:40:39PM -0700, Junio C Hamano wrote: > > Interesting. I don't get any such warning on repack. And RelNotes points > > to a file, so I'm not sure why stat() would make us think it was a dir. > > Interesting. The command in question is > > git-pack-objects --keep-true-

Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Junio C Hamano
Jeff King writes: > On Wed, Sep 12, 2012 at 11:32:22PM -0700, Junio C Hamano wrote: > >> "git repack" started giving the above warning, and I am guessing >> that the recent 11e50b2 (attr: warn on inaccessible attribute files, >> 2012-08-21) exposed a bug where we ask stat(2) not lstat(2) by >> mi

Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Jeff King
On Wed, Sep 12, 2012 at 11:32:22PM -0700, Junio C Hamano wrote: > "git repack" started giving the above warning, and I am guessing > that the recent 11e50b2 (attr: warn on inaccessible attribute files, > 2012-08-21) exposed a bug where we ask stat(2) not lstat(2) by > mistake before deciding to ap

{bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-12 Thread Junio C Hamano
"git repack" started giving the above warning, and I am guessing that the recent 11e50b2 (attr: warn on inaccessible attribute files, 2012-08-21) exposed a bug where we ask stat(2) not lstat(2) by mistake before deciding to append .gitattributes to see if that directory has a per-directory attribut