Re: [musl] Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-11 Thread Junio C Hamano
Jeff King writes: > Another difference I found is that "[\d]" matches a literal "\" or "d" > in ERE, but behaves like "[0-9]" in PCRE. I'll work up a patch based on > that. Wow, clever. Thanks.

Re: [musl] Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-11 Thread Jeff King
On Tue, Jan 10, 2017 at 12:40:00PM +0100, Szabolcs Nagy wrote: > > > I'm not sure if musl is wrong for failing to complain about a > > > bogus regex. Generally making something that would break into > > > something that works is an OK way to extend the standard. So our > > > test is at fault for a

Re: [musl] Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-10 Thread Szabolcs Nagy
* A. Wilcox [2017-01-10 04:36:50 -0600]: > On 09/01/17 15:33, Jeff King wrote: > > The problem is that we are expecting the regex "\x{2b}" to complain > > in regcomp() (as an ERE), but it doesn't. And that probably _is_ > > related to musl, which is providing the libc regex (I know this > > looks