Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

2017-06-15 Thread Jonathan Tan
On Thu, 15 Jun 2017 16:28:24 -0400 Jeff Hostetler wrote: > I agree with Peff here. I've been working on my partial/narrow/sparse > clone/fetch ideas since my original RFC and have come to the conclusion > that the server can do the size limiting efficiently, but we should > leave the pathname fi

Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

2017-06-15 Thread Jeff Hostetler
On 6/2/2017 6:26 PM, Jeff King wrote: On Fri, Jun 02, 2017 at 12:38:45PM -0700, Jonathan Tan wrote: ... We have a name-hash cache extension in the bitmap file, but it doesn't carry enough information to deduce the .git-ness of a file. I don't think it would be too hard to add a "flags" extens

Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

2017-06-07 Thread Jeff King
On Fri, Jun 02, 2017 at 04:25:08PM -0700, Jonathan Nieder wrote: > > We have a name-hash cache extension in the bitmap file, but it doesn't > > carry enough information to deduce the .git-ness of a file. I don't > > think it would be too hard to add a "flags" extension, and give a single > > bit t

Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

2017-06-03 Thread Junio C Hamano
Jeff King writes: > I do also wonder if the two features would need to be separated for a > GVFS-style solution. If you're not just avoiding large blobs but trying > to get a narrow clone, you don't want the .git files from the > uninteresting parts of the tree. You want to get no blobs at all, a

Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

2017-06-02 Thread Jonathan Nieder
Jeff King wrote: > On Fri, Jun 02, 2017 at 12:38:45PM -0700, Jonathan Tan wrote: >> +--blob-max-bytes=:: >> +This option can only be used with --stdout. If specified, a blob >> +larger than this will not be packed unless a to-be-packed tree >> +has that blob with a filename beginning w

Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

2017-06-02 Thread Jeff King
On Fri, Jun 02, 2017 at 12:38:45PM -0700, Jonathan Tan wrote: > +--blob-max-bytes=:: > + This option can only be used with --stdout. If specified, a blob > + larger than this will not be packed unless a to-be-packed tree > + has that blob with a filename beginning with ".git". The siz

[WIP v2 2/2] pack-objects: support --blob-max-bytes

2017-06-02 Thread Jonathan Tan
As part of an effort to improve Git support for very large repositories in which clients typically have only a subset of all version-controlled blobs, teach pack-objects to support --blob-max-bytes, packing only blobs not exceeding that size unless the blob corresponds to a file whose name starts w