Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-30 Thread Matthieu Moy
Samuel GROOT writes: > Can we consider this feature obsolete and remove it? We're usually quite conservative with backward compatibility. If we remove the feature, we may want to announce it in the next feature release and actually remove it in the one after (unless we get valid objection in the

Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-30 Thread Samuel GROOT
On 05/30/2016 04:20 PM, Matthieu Moy wrote: Is the "lots of email" format still used? AFAICT, it was initially supported for backward compatibility, and then no one removed it, but I wouldn't be surprised if no one actually used it. I vaguely remember a message from Ryan Anderson being surpris

Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-30 Thread Matthieu Moy
Samuel GROOT writes: > (mbox) prefix was introduced by Ryan Anderson in 2005 (can't find the > exact commit though), in opposition with the (non-mbox) format ("lots > of email") that was used before. That is actually from the original commit introducing send-email: 83b2443 ([PATCH] Add git-send-

Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-30 Thread Samuel GROOT
On 05/29/2016 08:05 PM, Matthieu Moy wrote: Samuel GROOT writes: Should we take what Eric suggested (see below) as standard output? Since the headers are already shown after those lines, it's redundant to have the entire line. And we could add trailers after the headers (with a blank line t

Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-29 Thread Matthieu Moy
Samuel GROOT writes: > Should we take what Eric suggested (see below) as standard output? > >> Since the headers are already shown after those lines, it's >> redundant to have the entire line. And we could add >> trailers after the headers (with a blank line to delimit): >> >> # existing hea

Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-29 Thread Samuel GROOT
On 05/28/2016 05:04 PM, Matthieu Moy wrote: Eric Wong writes: Samuel GROOT wrote: (mbox) Adding cc: A from line 'Cc: A, One' (mbox) Adding cc: One from line 'Cc: A, One' Though `git send-email` now outputs something like: (mbox) Adding cc: A from line 'Cc: A' (mbox) Addi

Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-28 Thread Matthieu Moy
Eric Wong writes: > Samuel GROOT wrote: > >>(mbox) Adding cc: A from line 'Cc: >> A, One' >>(mbox) Adding cc: One from line 'Cc: >> A, One' >> >> Though `git send-email` now outputs something like: >> >>(mbox) Adding cc: A from line 'Cc: >> A' >>(mbox) Adding cc: One fro

Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-27 Thread Eric Wong
Samuel GROOT wrote: > While working on the new option `quote-email`, we needed to parse an > email file. Since the work is already done, but the parsing and data > processing are in the same loop, we wanted to refactor the parser, to > make the code more maintainable. Thank you for doing this wor

[WIP-PATCH 0/2] send-email: refactor the email parser loop

2016-05-27 Thread Samuel GROOT
While working on the new option `quote-email`, we needed to parse an email file. Since the work is already done, but the parsing and data processing are in the same loop, we wanted to refactor the parser, to make the code more maintainable. This is still WIP, and one of the main issue (and we need