Re: [RFC PATCH v2 2/2] trace2: don't overload target directories

2019-08-05 Thread Josh Steadmon
On 2019.08.05 11:34, Jeff Hostetler wrote: > > > On 8/2/2019 6:02 PM, Josh Steadmon wrote: > > trace2 can write files into a target directory. With heavy usage, this > > directory can fill up with files, causing difficulty for > > trace-processing systems. > > > > This patch adds a config option

Re: [RFC PATCH v2 2/2] trace2: don't overload target directories

2019-08-05 Thread Josh Steadmon
On 2019.08.05 20:01, SZEDER Gábor wrote: > On Fri, Aug 02, 2019 at 03:02:35PM -0700, Josh Steadmon wrote: > > +test_expect_success "don't overload target directory" ' > > + mkdir trace_target_dir && > > + test_when_finished "rm -r trace_target_dir" && > > + ( > > + GIT_TRACE2_MAX_FI

Re: [RFC PATCH v2 2/2] trace2: don't overload target directories

2019-08-05 Thread SZEDER Gábor
On Fri, Aug 02, 2019 at 03:02:35PM -0700, Josh Steadmon wrote: > +test_expect_success "don't overload target directory" ' > + mkdir trace_target_dir && > + test_when_finished "rm -r trace_target_dir" && > + ( > + GIT_TRACE2_MAX_FILES=5 && > + export GIT_TRACE2_MA

Re: [RFC PATCH v2 2/2] trace2: don't overload target directories

2019-08-05 Thread Jeff Hostetler
On 8/2/2019 6:02 PM, Josh Steadmon wrote: trace2 can write files into a target directory. With heavy usage, this directory can fill up with files, causing difficulty for trace-processing systems. This patch adds a config option (trace2.maxFiles) to set a maximum number of files that trace2 wi

[RFC PATCH v2 2/2] trace2: don't overload target directories

2019-08-02 Thread Josh Steadmon
trace2 can write files into a target directory. With heavy usage, this directory can fill up with files, causing difficulty for trace-processing systems. This patch adds a config option (trace2.maxFiles) to set a maximum number of files that trace2 will write to a target directory. The following b