Re: [RFC PATCH v2 1/5] branch: improve documentation and naming of certain parameters

2017-10-20 Thread Kaartic Sivaraam
On Fri, 2017-10-20 at 17:51 -0400, Eric Sunshine wrote: > On Mon, Sep 25, 2017 at 1:20 AM, Kaartic Sivaraam > wrote: > > Documentation for a certain function was incomplete as it didn't say > > what certain parameters were used for. Further a parameter name wasn't > > very communicative. > > > >

Re: [RFC PATCH v2 1/5] branch: improve documentation and naming of certain parameters

2017-10-20 Thread Kaartic Sivaraam
On Fri, 2017-10-20 at 14:33 -0700, Stefan Beller wrote: > Up to here ( including the subject line), I have no idea you're talking about > 'create_branch'. Maybe > That's because I didn't want to be explicit. > branch: improve documentation and naming of parameters for create_branch > >

Re: [RFC PATCH v2 1/5] branch: improve documentation and naming of certain parameters

2017-10-20 Thread Eric Sunshine
On Mon, Sep 25, 2017 at 1:20 AM, Kaartic Sivaraam wrote: > Documentation for a certain function was incomplete as it didn't say > what certain parameters were used for. Further a parameter name wasn't > very communicative. > > So, add missing documentation for the sake of completeness and easy > r

Re: [RFC PATCH v2 1/5] branch: improve documentation and naming of certain parameters

2017-10-20 Thread Stefan Beller
On Mon, Sep 25, 2017 at 1:20 AM, Kaartic Sivaraam wrote: > Documentation for a certain function was incomplete as it didn't say > what certain parameters were used for. Further a parameter name wasn't > very communicative. > > So, add missing documentation for the sake of completeness and easy > r

[RFC PATCH v2 1/5] branch: improve documentation and naming of certain parameters

2017-09-25 Thread Kaartic Sivaraam
Documentation for a certain function was incomplete as it didn't say what certain parameters were used for. Further a parameter name wasn't very communicative. So, add missing documentation for the sake of completeness and easy reference. Also, rename the concerned parameter to make it's name more