Jeffrey Smith writes:
> On Mon, May 15, 2017 at 7:23 PM, Junio C Hamano wrote:
>> Jeffrey Smith writes:
>>
>>> I did try to keep any unnecessary changes out of the big movement
>>> patches (17-19). Would you prefer I break down 19 further? I had
>>> been holding back because of the added chur
Hm, I really thought I had split some of those out. Patches 4, 5, 17, and 19
could all be reasonably split into rename vs move patches. Patch 18 only
does moving.
I do not see much benefit to splitting up the 'move xyz to scoreboard'
subset (6-12) that way as moving an item to scoreboard is alre
Jeffrey Smith writes:
> On Mon, May 15, 2017 at 4:24 AM, Junio C Hamano wrote:
>> Jeff Smith writes:
>>
>>> Rather than duplicate large portions of builtin/blame.c in cgit, it
>>> would be better to shift its core functionality into libgit.a. The
>>> functionality left in builtin/blame.c mostl
I did try to keep any unnecessary changes out of the big movement
patches (17-19). Would you prefer I break down 19 further? I had
been holding back because of the added churn that would introduce from
lots of changing function visibility in blame.h and blame.c.
(And if gmail would quit trying t
Jeff Smith writes:
> Rather than duplicate large portions of builtin/blame.c in cgit, it
> would be better to shift its core functionality into libgit.a. The
> functionality left in builtin/blame.c mostly relates to terminal
> presentation.
As I said in my review of 04/22, it is a bit hard/tedi
Rather than duplicate large portions of builtin/blame.c in cgit, it
would be better to shift its core functionality into libgit.a. The
functionality left in builtin/blame.c mostly relates to terminal
presentation.
Since initial patchset:
Made commit titles consistent
Broke some commits into m
6 matches
Mail list logo
