Re: [RFC PATCH 3/5] format-patch: extend --range-diff to accept revision range

2018-07-17 Thread Eric Sunshine
On Tue, Jul 17, 2018 at 6:45 AM Johannes Schindelin wrote: > On Wed, 30 May 2018, Eric Sunshine wrote: > > + if (strstr(prev, "..")) { > > + if (!origin) > > + die(_("failed to infer range-diff ranges")); > > + argv_array_push(args, prev); > > +

Re: [RFC PATCH 3/5] format-patch: extend --range-diff to accept revision range

2018-07-17 Thread Johannes Schindelin
Hi Eric, On Wed, 30 May 2018, Eric Sunshine wrote: > diff --git a/builtin/log.c b/builtin/log.c > index 460c31a293..e38cf06050 100644 > --- a/builtin/log.c > +++ b/builtin/log.c > @@ -995,10 +995,20 @@ static char *find_branch_name(struct rev_info *rev) > > static void infer_diff_ranges(struct

Re: [RFC PATCH 3/5] format-patch: extend --range-diff to accept revision range

2018-05-30 Thread Eric Sunshine
On Wed, May 30, 2018 at 2:58 PM, Stefan Beller wrote: > On Wed, May 30, 2018 at 1:03 AM, Eric Sunshine > wrote: >> When submitting a revised a patch series, the --range-diff option embeds >> a range-diff in the cover letter showing changes since the previous >> version of the patch series. The a

Re: [RFC PATCH 3/5] format-patch: extend --range-diff to accept revision range

2018-05-30 Thread Stefan Beller
On Wed, May 30, 2018 at 1:03 AM, Eric Sunshine wrote: > When submitting a revised a patch series, the --range-diff option embeds > a range-diff in the cover letter showing changes since the previous > version of the patch series. The argument to --range-diff is a simple > revision naming the tip o

[RFC PATCH 3/5] format-patch: extend --range-diff to accept revision range

2018-05-30 Thread Eric Sunshine
When submitting a revised a patch series, the --range-diff option embeds a range-diff in the cover letter showing changes since the previous version of the patch series. The argument to --range-diff is a simple revision naming the tip of the previous series, which works fine if the previous and cur