Re: [RFC PATCH 3/4] range-diff: add section header instead of diff header

2019-04-15 Thread Thomas Gummerer
On 04/15, Johannes Schindelin wrote: > Hi Eric, > > On Sun, 14 Apr 2019, Eric Sunshine wrote: > > > On Sun, Apr 14, 2019 at 5:10 PM Thomas Gummerer > > wrote: > > > [...] > > > Introduce a new range diff hunk header, that's enclosed by "##", > > > similar to how line numbers in diff hunks are e

Re: [RFC PATCH 3/4] range-diff: add section header instead of diff header

2019-04-15 Thread Johannes Schindelin
Hi Eric, On Sun, 14 Apr 2019, Eric Sunshine wrote: > On Sun, Apr 14, 2019 at 5:10 PM Thomas Gummerer wrote: > > [...] > > Introduce a new range diff hunk header, that's enclosed by "##", > > similar to how line numbers in diff hunks are enclosed by "@@", and > > give human readable information o

Re: [RFC PATCH 3/4] range-diff: add section header instead of diff header

2019-04-14 Thread Johannes Sixt
Am 15.04.19 um 01:29 schrieb Eric Sunshine: > On Sun, Apr 14, 2019 at 5:10 PM Thomas Gummerer wrote: >> + strbuf_remove(&line, 0, 4); >> + if (!strcmp(filename_a.buf, "/dev/null")) { >> + strbuf_addstr(&buf, "new fil

Re: [RFC PATCH 3/4] range-diff: add section header instead of diff header

2019-04-14 Thread Eric Sunshine
On Sun, Apr 14, 2019 at 5:10 PM Thomas Gummerer wrote: > [...] > Introduce a new range diff hunk header, that's enclosed by "##", > similar to how line numbers in diff hunks are enclosed by "@@", and > give human readable information of what exactly happened to the file, > including the file name.

[RFC PATCH 3/4] range-diff: add section header instead of diff header

2019-04-14 Thread Thomas Gummerer
Currently range-diff keeps the diff header of the inner diff intact (apart from stripping lines starting with index). This diff header is somewhat useful, especially when files get different names in different ranges. However there is no real need to keep the whole diff header for that. The main