Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2019-01-22 Thread Johannes Schindelin
Hi Elijah, On Mon, 21 Jan 2019, Elijah Newren wrote: > Before worrying about adding extra options and deprecation periods, > though, perhaps we could start by by omitting the --cherry-pick for > implicitly_interactive rebases, like --merge? (In particular, I'm > thinking that when we switch the

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2019-01-21 Thread Elijah Newren
Hi Dscho, On Mon, Jan 21, 2019 at 7:56 AM Johannes Schindelin wrote: > > Hi Elijah, > > while looking for the patches I promised to review much earlier, I > realized that I never answered to this, even older mail. Sorry about that. > > [On a positive note: it only has been, what, exactly 7 months

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2019-01-21 Thread Johannes Schindelin
Hi Elijah, while looking for the patches I promised to review much earlier, I realized that I never answered to this, even older mail. Sorry about that. [On a positive note: it only has been, what, exactly 7 months since you sent it. My record is, I believe, somewhat around 5 years before I respo

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2018-06-21 Thread Elijah Newren
Hi Dscho, Thanks for all the food for thought. This is awesome. On Thu, Jun 21, 2018 at 3:57 AM, Johannes Schindelin wrote: > On Wed, 20 Jun 2018, Elijah Newren wrote: >> On Sun, Jun 17, 2018 at 2:44 PM, Johannes Schindelin >> wrote: >> >> > I was really referring to speed. But I have to admit

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2018-06-21 Thread Johannes Schindelin
Hi Elijah, On Wed, 20 Jun 2018, Elijah Newren wrote: > On Sun, Jun 17, 2018 at 2:44 PM, Johannes Schindelin > wrote: > > > I was really referring to speed. But I have to admit that I do not have > > any current numbers. > > > > Another issue just hit me, though: rebase --am does not need to loo

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2018-06-20 Thread Elijah Newren
Hi Dscho, On Sun, Jun 17, 2018 at 2:44 PM, Johannes Schindelin wrote: > I was really referring to speed. But I have to admit that I do not have > any current numbers. > > Another issue just hit me, though: rebase --am does not need to look at as > many Git objects as rebase --merge or rebase -i.

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2018-06-17 Thread Johannes Schindelin
Hi Elijah, On Sat, 9 Jun 2018, Elijah Newren wrote: > On Sat, Jun 9, 2018 at 3:11 PM, Johannes Schindelin > wrote: > > On Thu, 7 Jun 2018, Elijah Newren wrote: > > > >> am-based rebases suffer from an reduced ability to detect directory > >> renames upstream, which is fundamental to the fact tha

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2018-06-09 Thread Elijah Newren
Hi Dscho, On Sat, Jun 9, 2018 at 3:11 PM, Johannes Schindelin wrote: > On Thu, 7 Jun 2018, Elijah Newren wrote: > >> am-based rebases suffer from an reduced ability to detect directory >> renames upstream, which is fundamental to the fact that it throws away >> information about the history: in p

Re: [RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2018-06-09 Thread Johannes Schindelin
Hi Elijah, On Thu, 7 Jun 2018, Elijah Newren wrote: > am-based rebases suffer from an reduced ability to detect directory > renames upstream, which is fundamental to the fact that it throws away > information about the history: in particular, it dispenses with the > original commits involved by t

[RFC PATCH 3/3] git-rebase.sh: make git-rebase--interactive the default

2018-06-07 Thread Elijah Newren
am-based rebases suffer from an reduced ability to detect directory renames upstream, which is fundamental to the fact that it throws away information about the history: in particular, it dispenses with the original commits involved by turning them into patches, and without the knowledge of the ori