Re: [RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

On 04/17, Johannes Schindelin wrote: > Hi Thomas, > > On Mon, 15 Apr 2019, Thomas Gummerer wrote: > > I like declaring this a bug. We are after all parsing > > machine-generated output, that does come from git (which is why I > > neglected the NULL checking in the first place). If that second "@

Re: [RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

Hi Thomas, On Mon, 15 Apr 2019, Thomas Gummerer wrote: > On 04/15, Johannes Schindelin wrote: > > > On Sun, 14 Apr 2019, Eric Sunshine wrote: > > > > > On Sun, Apr 14, 2019 at 5:09 PM Thomas Gummerer > > > wrote: > > > > [...] > > > > However it can still be useful to have the function name tha

Re: [RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

On 04/15, Johannes Schindelin wrote: > Hi Thomas, > > > On Sun, 14 Apr 2019, Thomas Gummerer wrote: > > diff --git a/range-diff.c b/range-diff.c > > index 9242b8975f..f365141ade 100644 > > --- a/range-diff.c > > +++ b/range-diff.c > > @@ -102,9 +102,12 @@ static int read_patches(const char *range

Re: [RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

On 04/15, Johannes Schindelin wrote: > Hi Eric, > > On Sun, 14 Apr 2019, Eric Sunshine wrote: > > > On Sun, Apr 14, 2019 at 5:09 PM Thomas Gummerer > > wrote: > > > [...] > > > However it can still be useful to have the function name that 'git > > > diff' extracts as additional context for the

Re: [RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

Hi Eric, On Sun, 14 Apr 2019, Eric Sunshine wrote: > On Sun, Apr 14, 2019 at 5:09 PM Thomas Gummerer wrote: > > [...] > > However it can still be useful to have the function name that 'git > > diff' extracts as additional context for the change. > > [...] > > Signed-off-by: Thomas Gummerer > >

Re: [RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

Hi Thomas, On Sun, 14 Apr 2019, Thomas Gummerer wrote: > When postprocessing the inner diff in range-diff, we currently replace > the whole hunk header line with just "@@". This matches how 'git > tbdiff' used to handle hunk headers as well. > > Most likely this is being done because line numbe

Re: [RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

On Sun, Apr 14, 2019 at 5:09 PM Thomas Gummerer wrote: > [...] > However it can still be useful to have the function name that 'git > diff' extracts as additional context for the change. > [...] > Signed-off-by: Thomas Gummerer > --- > diff --git a/range-diff.c b/range-diff.c > @@ -102,9 +102,12

[RFC PATCH 2/4] range-diff: don't remove funcname from inner diff

When postprocessing the inner diff in range-diff, we currently replace the whole hunk header line with just "@@". This matches how 'git tbdiff' used to handle hunk headers as well. Most likely this is being done because line numbers in the hunk header are not relevant without other changes. They