Re: [RFC PATCH 08/11] rebase -i: use struct rebase_options to parse args

Hi Alban sorry for the slow reply, I think you're probably off-list for a while by now On 21/03/2019 21:13, Alban Gruin wrote: Hi Phillip, It’s nice to see your work on this on the list. Le 19/03/2019 à 20:03, Phillip Wood a écrit : From: Phillip Wood In order to run `rebase -i` without

Re: [RFC PATCH 08/11] rebase -i: use struct rebase_options to parse args

Phillip Wood writes: > Hi Junio > > On 21/03/2019 04:21, Junio C Hamano wrote: >> Phillip Wood writes: >> >>> +static struct replay_opts get_replay_opts(const struct rebase_options >>> *opts) >>> +{ >>> + struct replay_opts replay = REPLAY_OPTS_INIT; >>> + >>> + sequencer_init_config(&repla

Re: [RFC PATCH 08/11] rebase -i: use struct rebase_options to parse args

Hi Phillip, It’s nice to see your work on this on the list. Le 19/03/2019 à 20:03, Phillip Wood a écrit : > From: Phillip Wood > > In order to run `rebase -i` without forking `rebase--interactive` it > will be convenient to use the same structure when parsing the options in > cmd_rebase() and c

Re: [RFC PATCH 08/11] rebase -i: use struct rebase_options to parse args

Hi Junio On 21/03/2019 04:21, Junio C Hamano wrote: Phillip Wood writes: +static struct replay_opts get_replay_opts(const struct rebase_options *opts) +{ + struct replay_opts replay = REPLAY_OPTS_INIT; + + sequencer_init_config(&replay); + + replay.action = REPLAY_INTERACTIV

Re: [RFC PATCH 08/11] rebase -i: use struct rebase_options to parse args

Phillip Wood writes: > +static struct replay_opts get_replay_opts(const struct rebase_options *opts) > +{ > + struct replay_opts replay = REPLAY_OPTS_INIT; > + > + sequencer_init_config(&replay); > + > + replay.action = REPLAY_INTERACTIVE_REBASE; > + replay.signoff = opts->signoff

[RFC PATCH 08/11] rebase -i: use struct rebase_options to parse args

From: Phillip Wood In order to run `rebase -i` without forking `rebase--interactive` it will be convenient to use the same structure when parsing the options in cmd_rebase() and cmd_rebase__interactive(). Signed-off-by: Phillip Wood --- builtin/rebase.c | 203 ++