Re: [RFC PATCH 01/13] commit-reach: move walk methods from commit.c

2018-06-29 Thread Junio C Hamano
Derrick Stolee writes: > Signed-off-by: Derrick Stolee > --- > Makefile | 1 + > commit-reach.c | 359 + > commit-reach.h | 41 ++ > commit.c | 358 > 4 files changed, 401 inserti

Re: [RFC PATCH 01/13] commit-reach: move walk methods from commit.c

2018-06-29 Thread Stefan Beller
Hi Derrick, > +/* Remember to update object flag allocation in object.h */ > +#define PARENT1 (1u<<16) > +#define PARENT2 (1u<<17) > +#define STALE (1u<<18) > +#define RESULT (1u<<19) Something is up with whitespaces here, apart from that this patch looks good.

[RFC PATCH 01/13] commit-reach: move walk methods from commit.c

2018-06-29 Thread Derrick Stolee
Signed-off-by: Derrick Stolee --- Makefile | 1 + commit-reach.c | 359 + commit-reach.h | 41 ++ commit.c | 358 4 files changed, 401 insertions(+), 358 deletions(-) create mode 1