Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Jeff King
On Wed, Apr 19, 2017 at 02:22:47PM -0700, Jacob Keller wrote: > > I think the breakage in that case would be caused by "--no-stage" taking > > over "--stage" as well. And your patch doesn't change that; it happened > > already in 2012. > > > > Your patch only affects the --no-no- form, which I thi

Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Jacob Keller
On Wed, Apr 19, 2017 at 2:22 PM, Jacob Keller wrote: > On Wed, Apr 19, 2017 at 2:00 PM, Jeff King wrote: >> On Wed, Apr 19, 2017 at 01:54:06PM -0700, Jacob Keller wrote: >> >>> This is why it's an RFC. I don't really feel that it's too much of a >>> problem. As for the reason why I thought it mig

Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Jacob Keller
On Wed, Apr 19, 2017 at 2:00 PM, Jeff King wrote: > On Wed, Apr 19, 2017 at 01:54:06PM -0700, Jacob Keller wrote: > >> This is why it's an RFC. I don't really feel that it's too much of a >> problem. As for the reason why I thought it might want a flag itself >> is because of concerns raised earli

Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Jeff King
On Wed, Apr 19, 2017 at 01:54:06PM -0700, Jacob Keller wrote: > This is why it's an RFC. I don't really feel that it's too much of a > problem. As for the reason why I thought it might want a flag itself > is because of concerns raised earlier that we might have something > liek > > OPT_BOOL( ...

Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Jacob Keller
On Wed, Apr 19, 2017 at 8:10 AM, Jeff King wrote: > On Wed, Apr 19, 2017 at 02:08:20AM -0700, Jacob Keller wrote: > >> From: Jacob Keller >> >> Many options can be negated by prefixing the option with "no-", for >> example "--3way" can be prefixed with "--no-3way" to disable it. Since >> 0f1930c5

Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Jeff King
On Wed, Apr 19, 2017 at 02:08:20AM -0700, Jacob Keller wrote: > From: Jacob Keller > > Many options can be negated by prefixing the option with "no-", for > example "--3way" can be prefixed with "--no-3way" to disable it. Since > 0f1930c58754 ("parse-options: allow positivation of options > star

Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread René Scharfe
Am 19.04.2017 um 11:08 schrieb Jacob Keller: From: Jacob Keller Many options can be negated by prefixing the option with "no-", for example "--3way" can be prefixed with "--no-3way" to disable it. Since 0f1930c58754 ("parse-options: allow positivation of options starting, with no-", 2012-02-25)

Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 19, 2017 at 11:08 AM, Jacob Keller wrote: > Many options can be negated by prefixing the option with "no-", for > example "--3way" can be prefixed with "--no-3way" to disable it. Since > 0f1930c58754 ("parse-options: allow positivation of options > starting, with no-", 2012-02-25) we h

[RFC PATCH] parse-options: disallow double-negations of options starting with no-

2017-04-19 Thread Jacob Keller
From: Jacob Keller Many options can be negated by prefixing the option with "no-", for example "--3way" can be prefixed with "--no-3way" to disable it. Since 0f1930c58754 ("parse-options: allow positivation of options starting, with no-", 2012-02-25) we have also had support to negate options whi