Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to remote-helper.

2012-07-22 Thread Jonathan Nieder
Hi, Florian Achleitner wrote: > On Windows, processses are not forked but spawned from new and therefore > can't > inherit pipe file descriptors. Ok, this is what I didn't understand (and still don't understand). Yes, on Windows processes are spawned instead of forked. But does that mean the

Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to remote-helper.

2012-07-22 Thread Florian Achleitner
On Saturday 21 July 2012 10:44:37 Jonathan Nieder wrote: > Florian Achleitner wrote: > > On Saturday 21 July 2012 09:48:34 Jonathan Nieder wrote: > >> To sum up: I think we should just stick to pipes --- why all this fifo > >> complication? > > > > People didn't like pipe variant (prexec_cb not be

Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to remote-helper.

2012-07-21 Thread Jonathan Nieder
(adding msysgit list to cc for a Windows question) Hi, (regarding bidirectional communication between git and fast-import for remote helpers) Florian Achleitner wrote: > People didn't like pipe variant (prexec_cb not being compatible to windows' > process creation model), so I learned about fifo

Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to remote-helper.

2012-07-21 Thread Jonathan Nieder
Florian Achleitner wrote: > On Saturday 21 July 2012 09:48:34 Jonathan Nieder wrote: >> To sum up: I think we should just stick to pipes --- why all this fifo >> complication? > > People didn't like pipe variant (prexec_cb not being compatible to windows' > process creation model), so I learned a

Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to remote-helper.

2012-07-21 Thread Florian Achleitner
On Saturday 21 July 2012 09:48:34 Jonathan Nieder wrote: > To sum up: I think we should just stick to pipes --- why all this fifo > complication? People didn't like pipe variant (prexec_cb not being compatible to windows' process creation model), so I learned about fifos and implemented a (basic)

Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to remote-helper.

2012-07-21 Thread Jonathan Nieder
Hi, Florian Achleitner wrote: > [Subject: Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to > remote-helper.] Is this on top of patches 1, 2, and 3 from v2 of the series? *checks* Looks like it doesn't overlap with any of the files from those patches, so I don't ha

Re: [RFC 4/4 v3] Add cat-blob report fifo from fast-import to remote-helper.

2012-07-21 Thread Florian Achleitner
For some fast-import commands (e.g. cat-blob) an answer-channel is required. For this purpose a fifo (aka named pipe) (mkfifo) is created (.git/fast-import-report-fifo) by the transport-helper when fetch via import is requested. The remote-helper and fast-import open the ends of the pipe. The file