Re: [msysGit] Re: [RFC 3/4] engine.pl: split the .o and .obj processing

2014-11-23 Thread Philip Oakley
From: "Johannes Schindelin" > How about the following instead? > > + } elsif ($part eq 'invalidcontinue.obj') { > + # ignore > } elsif ($part =~ /\.(o|obj)$/) { Looks good, I'll use that (after deciding whether .obj files should be expected in a 'make' output anyway) My idea to hardcode inva

Re: [RFC 3/4] engine.pl: split the .o and .obj processing

2014-11-23 Thread Johannes Schindelin
Hi, On Fri, 21 Nov 2014, Philip Oakley wrote: > From: "Johannes Schindelin" > > > On Thu, 20 Nov 2014, Philip Oakley wrote: > > > > > @@ -343,8 +346,10 @@ sub handleLinkLine > > > } elsif ($part =~ /\.(a|lib)$/) { > > > $part =~ s/\.a$/.lib/; > > > push(@libs,

Re: [RFC 3/4] engine.pl: split the .o and .obj processing

2014-11-21 Thread Philip Oakley
From: "Johannes Schindelin" Hi Philip, On Thu, 20 Nov 2014, Philip Oakley wrote: Commit 4b623d80f7352 added an .obj file (invalidcontinue.obj) which was not processed correctly. The generate engine then mistakenly did a s/.o/.c/ to create a request to compile invalidcontinue.cbj. This

Re: [RFC 3/4] engine.pl: split the .o and .obj processing

2014-11-21 Thread Johannes Schindelin
Hi Philip, On Thu, 20 Nov 2014, Philip Oakley wrote: > Commit 4b623d80f7352 added an .obj file (invalidcontinue.obj) which was not > processed correctly. > > The generate engine then mistakenly did a s/.o/.c/ to create a request > to compile invalidcontinue.cbj. This is good. However, this: >

[RFC 3/4] engine.pl: split the .o and .obj processing

2014-11-20 Thread Philip Oakley
Commit 4b623d80f7352 added an .obj file (invalidcontinue.obj) which was not processed correctly. The generate engine then mistakenly did a s/.o/.c/ to create a request to compile invalidcontinue.cbj. Split the '/\.(o|obj)$' in engine.pl#L353 into: } elsif ($part =~ /\.o$/) { # was '/\.(