Re: [RFC] test_when_finished in subshells

2015-09-05 Thread Jeff King
On Fri, Sep 04, 2015 at 11:43:15AM -0700, Junio C Hamano wrote: > > t7800 (in its final test) calls test_config in a subshell which has cd'd > > into a submodule. > > > > Is this something worth worrying about, or is it sufficiently rare that > > we can live with the current behaviour? > > Fixing

Re: [RFC] test_when_finished in subshells

2015-09-04 Thread Junio C Hamano
John Keeping writes: > All are harmless at the moment and t7610 and t5801 can be fixed by > moving the test_when_finished call out of the subshell relatively > easily. > > t7800 (in its final test) calls test_config in a subshell which has cd'd > into a submodule. > > Is this something worth worr

[RFC] test_when_finished in subshells

2015-09-04 Thread John Keeping
A recent thread [0] made me realise that using test_when_finished in a subshell is likely to be a bug, since the change to $test_cleanup will be lost when the subshell exits. There is no POSIX way to detect that we are in a subshell ($$ and $PPID are specified to remain unchanged), but we can dete