Re: [RFC] stash --continue

2017-01-20 Thread Johannes Schindelin
Hi Marc, On Fri, 20 Jan 2017, Marc Branchaud wrote: > On 2017-01-19 04:30 PM, Johannes Schindelin wrote: > > > > At this point I will stop commenting on this issue, as I have said all > > that I wanted to say about it, at least once. If I failed to get my > > points across so far, I simply won't

Re: [RFC] stash --continue

2017-01-20 Thread Marc Branchaud
On 2017-01-19 04:30 PM, Johannes Schindelin wrote: At this point I will stop commenting on this issue, as I have said all that I wanted to say about it, at least once. If I failed to get my points across so far, I simply won't be understood. Yes, we're obviously looking at this from completely

Re: [RFC] stash --continue

2017-01-19 Thread Johannes Schindelin
Hi Marc, On Thu, 19 Jan 2017, Marc Branchaud wrote: > On 2017-01-19 10:49 AM, Johannes Schindelin wrote: > > > > On Wed, 18 Jan 2017, Marc Branchaud wrote: > > > > > On 2017-01-18 11:34 AM, Johannes Schindelin wrote: > > > > > > > > On Wed, 18 Jan 2017, Marc Branchaud wrote: > > > > > > > > > On

Re: [RFC] stash --continue

2017-01-19 Thread Marc Branchaud
On 2017-01-19 10:49 AM, Johannes Schindelin wrote: Hi Marc, On Wed, 18 Jan 2017, Marc Branchaud wrote: On 2017-01-18 11:34 AM, Johannes Schindelin wrote: On Wed, 18 Jan 2017, Marc Branchaud wrote: On 2017-01-16 05:54 AM, Johannes Schindelin wrote: On Mon, 16 Jan 2017, Stephan Beyer wrote

Re: [RFC] stash --continue

2017-01-19 Thread Johannes Schindelin
Hi Stephan, On Wed, 18 Jan 2017, Stephan Beyer wrote: > PPS: Any opinions about the mentioned "backwards-compatibility" issue > that people are then forced to finish their commits with "--continue" > instead of "git reset" or "git commit"? Maybe you could make it so that "git reset" and "git com

Re: [RFC] stash --continue

2017-01-19 Thread Johannes Schindelin
Hi Marc, On Wed, 18 Jan 2017, Marc Branchaud wrote: > On 2017-01-18 11:34 AM, Johannes Schindelin wrote: > > > > On Wed, 18 Jan 2017, Marc Branchaud wrote: > > > > > On 2017-01-16 05:54 AM, Johannes Schindelin wrote: > > > > > > > On Mon, 16 Jan 2017, Stephan Beyer wrote: > > > > > > > > > a git-

Re: [RFC] stash --continue

2017-01-18 Thread Samuel Lijin
>> At least `git stash pop --continue` would be consistent with all other >> `--continue` options in Git that I can think of... > Alas, I disagree! I'm with Johannes here. "git stash" sans subcommand is pretty explicitly defined as "git stash save", so by similar logic, "git stash --continue", if

Re: [RFC] stash --continue

2017-01-18 Thread Stephan Beyer
Hi, On 01/18/2017 04:41 PM, Marc Branchaud wrote: > On 2017-01-16 05:54 AM, Johannes Schindelin wrote: >> On Mon, 16 Jan 2017, Stephan Beyer wrote: >>> a git-newbie-ish co-worker uses git-stash sometimes. Last time he used >>> "git stash pop", he got into a merge conflict. After he resolved the >>

Re: [RFC] stash --continue

2017-01-18 Thread Junio C Hamano
Johannes Schindelin writes: >> > More like "git stash pop --continue". Without the "pop" command, it >> > does not make too much sense. >> >> Why not? git should be able to remember what stash command created the >> conflict. Why should I have to? Maybe the fire alarm goes off right when I >>

Re: [RFC] stash --continue

2017-01-18 Thread Marc Branchaud
On 2017-01-18 11:34 AM, Johannes Schindelin wrote: Hi Marc, On Wed, 18 Jan 2017, Marc Branchaud wrote: On 2017-01-16 05:54 AM, Johannes Schindelin wrote: On Mon, 16 Jan 2017, Stephan Beyer wrote: a git-newbie-ish co-worker uses git-stash sometimes. Last time he used "git stash pop", he got

Re: [RFC] stash --continue

2017-01-18 Thread Johannes Schindelin
Hi Marc, On Wed, 18 Jan 2017, Marc Branchaud wrote: > On 2017-01-16 05:54 AM, Johannes Schindelin wrote: > > > On Mon, 16 Jan 2017, Stephan Beyer wrote: > > > > > a git-newbie-ish co-worker uses git-stash sometimes. Last time he > > > used "git stash pop", he got into a merge conflict. After he >

Re: [RFC] stash --continue

2017-01-18 Thread Marc Branchaud
On 2017-01-16 05:54 AM, Johannes Schindelin wrote: Hi Stephan, On Mon, 16 Jan 2017, Stephan Beyer wrote: a git-newbie-ish co-worker uses git-stash sometimes. Last time he used "git stash pop", he got into a merge conflict. After he resolved the conflict, he did not know what to do to get the r

Re: [RFC] stash --continue

2017-01-17 Thread Junio C Hamano
Stephan Beyer writes: > This led to the idea to have something like "git stash --continue"[1] > that would expect the user to "git add" the resolved files (as "git > status" suggests) but then leads to the expected result, i.e. the index > being the same as before the conflict, the stash being dr

Re: [RFC] stash --continue

2017-01-16 Thread Johannes Schindelin
Hi Stephan, On Mon, 16 Jan 2017, Stephan Beyer wrote: > a git-newbie-ish co-worker uses git-stash sometimes. Last time he used > "git stash pop", he got into a merge conflict. After he resolved the > conflict, he did not know what to do to get the repository into the > wanted state. In his case,

Re: [RFC] stash --continue

2017-01-15 Thread Jacob Keller
On Sun, Jan 15, 2017 at 3:56 PM, Stephan Beyer wrote: > Hi, > > a git-newbie-ish co-worker uses git-stash sometimes. Last time he used > "git stash pop", he got into a merge conflict. After he resolved the > conflict, he did not know what to do to get the repository into the > wanted state. In his

[RFC] stash --continue

2017-01-15 Thread Stephan Beyer
Hi, a git-newbie-ish co-worker uses git-stash sometimes. Last time he used "git stash pop", he got into a merge conflict. After he resolved the conflict, he did not know what to do to get the repository into the wanted state. In his case, it was only "git add " followed by a "git reset" and a "git