Re: [RFC] send-email: support validate hook

2017-05-12 Thread Ævar Arnfjörð Bjarmason
On Sat, May 13, 2017 at 12:31 AM, Jonathan Tan wrote: > On 05/12/2017 12:23 AM, Ævar Arnfjörð Bjarmason wrote: >> >> I hacked this up last night, it also addresses Junio's comment about >> GIT_DIR: >> > [snip] >> >> >> Changes there: >> >> * use catdir instead of string concat, I don't know if we

Re: [RFC] send-email: support validate hook

2017-05-12 Thread Jonathan Tan
On 05/12/2017 12:23 AM, Ævar Arnfjörð Bjarmason wrote: I hacked this up last night, it also addresses Junio's comment about GIT_DIR: [snip] Changes there: * use catdir instead of string concat, I don't know if we run format-patch on any platform where this matters in theory (e.g. VMS I thin

Re: [RFC] send-email: support validate hook

2017-05-12 Thread Ævar Arnfjörð Bjarmason
On Thu, May 11, 2017 at 9:37 PM, Jonathan Tan wrote: > Currently, send-email has support for rudimentary e-mail validation. > Allow the user to add support for more validation by providing a > sendemail-validate hook. > > Signed-off-by: Jonathan Tan > --- > > This is motivated by situations in wh

Re: [RFC] send-email: support validate hook

2017-05-11 Thread Junio C Hamano
Jonathan Tan writes: > diff --git a/git-send-email.perl b/git-send-email.perl > index eea0a517f..7de91ca7c 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -27,6 +27,7 @@ use Term::ANSIColor; > use File::Temp qw/ tempdir tempfile /; > use File::Spec::Functions qw(catfile); >

Re: [RFC] send-email: support validate hook

2017-05-11 Thread Brandon Williams
On 05/11, Jonathan Tan wrote: > Currently, send-email has support for rudimentary e-mail validation. > Allow the user to add support for more validation by providing a > sendemail-validate hook. > > Signed-off-by: Jonathan Tan > --- > > This is motivated by situations in which we discuss a work

[RFC] send-email: support validate hook

2017-05-11 Thread Jonathan Tan
Currently, send-email has support for rudimentary e-mail validation. Allow the user to add support for more validation by providing a sendemail-validate hook. Signed-off-by: Jonathan Tan --- This is motivated by situations in which we discuss a work in progress using Gerrit (which requires Chang