Re: Re: [RFC/WIP PATCH] implement reading of submodule .gitmodules configuration into cache

2013-12-12 Thread Heiko Voigt
On Mon, Dec 09, 2013 at 03:37:50PM -0800, Junio C Hamano wrote: > > +void submodule_config_cache_free(struct submodule_config_cache *cache) > > +{ > > + /* NOTE: its important to iterate over the name hash here > > +* since paths might have multiple entries */ > > Style (multi-line comments)

Re: [RFC/WIP PATCH] implement reading of submodule .gitmodules configuration into cache

2013-12-09 Thread Junio C Hamano
Heiko Voigt writes: > This submodule configuration cache allows us to lazily read .gitmodules > configurations by commit into a runtime cache which can then be used to > easily lookup values from it. Currently only the values for path or name > are stored but it can be extended for any value need

[RFC/WIP PATCH] implement reading of submodule .gitmodules configuration into cache

2013-12-09 Thread Heiko Voigt
This submodule configuration cache allows us to lazily read .gitmodules configurations by commit into a runtime cache which can then be used to easily lookup values from it. Currently only the values for path or name are stored but it can be extended for any value needed. This cache can be used fo