Re: [RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands

2014-05-23 Thread Jeff King
On Fri, May 23, 2014 at 04:43:38PM +0200, Karsten Blees wrote: > Alright then. I've queued vor v5: > * add __FILE__ __LINE__ for all trace output, if the compiler supports > variadic macros > * add timestamp for all trace output > * perhaps move trace declarations to new trace.h > * improve commi

Re: [RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands

2014-05-23 Thread Karsten Blees
Am 22.05.2014 11:59, schrieb Jeff King: > On Thu, May 22, 2014 at 02:40:48AM +0200, Karsten Blees wrote: > >> E.g. if I'm interested in a particular code section, I throw in 2 >> lines of code (before and after the code section). This gives very >> accurate results, without significantly affecting

Re: [RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands

2014-05-22 Thread Jeff King
On Thu, May 22, 2014 at 02:40:48AM +0200, Karsten Blees wrote: > E.g. if I'm interested in a particular code section, I throw in 2 > lines of code (before and after the code section). This gives very > accurate results, without significantly affecting overall performance. > I can then push the cha

Re: [RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands

2014-05-21 Thread Karsten Blees
Am 21.05.2014 18:55, schrieb Jeff King: > On Tue, May 20, 2014 at 09:11:24PM +0200, Karsten Blees wrote: > >> Add performance tracing to identify which git commands are called and how >> long they execute. This is particularly useful to debug performance issues >> of scripted commands. >> >> Usage

Re: [RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands

2014-05-21 Thread Junio C Hamano
Jeff King writes: > On Tue, May 20, 2014 at 09:11:24PM +0200, Karsten Blees wrote: > >> Add performance tracing to identify which git commands are called and how >> long they execute. This is particularly useful to debug performance issues >> of scripted commands. >> >> Usage example: > GIT_TRAC

Re: [RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands

2014-05-21 Thread Jeff King
On Tue, May 20, 2014 at 09:11:24PM +0200, Karsten Blees wrote: > Add performance tracing to identify which git commands are called and how > long they execute. This is particularly useful to debug performance issues > of scripted commands. > > Usage example: > GIT_TRACE_PERFORMANCE=~/git-trace.lo

[RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands

2014-05-20 Thread Karsten Blees
Add performance tracing to identify which git commands are called and how long they execute. This is particularly useful to debug performance issues of scripted commands. Usage example: > GIT_TRACE_PERFORMANCE=~/git-trace.log git stash list Creates a log file like this: performance: at trace.c:31