Re: [RFC/PATCH v2 1/3] sh-setup: export GIT_DIR

2014-04-23 Thread Junio C Hamano
Jeff King writes: > On Wed, Apr 23, 2014 at 02:42:38PM -0500, Felipe Contreras wrote: > >> It is what the clients of this library expect. > > Is it? Passing GIT_DIR to sub-invocations of git will change how they > determine the repo and working tree. Your patch seems to cause failures > all over

Re: [RFC/PATCH v2 1/3] sh-setup: export GIT_DIR

2014-04-23 Thread Jeff King
On Wed, Apr 23, 2014 at 02:42:38PM -0500, Felipe Contreras wrote: > It is what the clients of this library expect. Is it? Passing GIT_DIR to sub-invocations of git will change how they determine the repo and working tree. Your patch seems to cause failures all over the test suite. Without lookin

[RFC/PATCH v2 1/3] sh-setup: export GIT_DIR

2014-04-23 Thread Felipe Contreras
It is what the clients of this library expect. Signed-off-by: Felipe Contreras --- git-sh-setup.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/git-sh-setup.sh b/git-sh-setup.sh index 5f28b32..fb0362f 100644 --- a/git-sh-setup.sh +++ b/git-sh-setup.sh @@ -346,6 +346,7 @@ then