Re: [RFC/PATCH v1 0/4] compat/obstack: update from upstream

2019-06-17 Thread SZEDER Gábor
On Fri, Jun 14, 2019 at 09:30:20PM +0100, Ramsay Jones wrote: > > > On 14/06/2019 11:00, SZEDER Gábor wrote: > > Update 'compat/obstack.{c,h}' from upstream, because they already use > > 'size_t' instead of 'long' in places that might eventually end up as > > an argument to malloc(), which might

Re: [RFC/PATCH v1 0/4] compat/obstack: update from upstream

2019-06-14 Thread Ramsay Jones
On 14/06/2019 21:30, Ramsay Jones wrote: > > > On 14/06/2019 11:00, SZEDER Gábor wrote: >> Update 'compat/obstack.{c,h}' from upstream, because they already use >> 'size_t' instead of 'long' in places that might eventually end up as >> an argument to malloc(), which might solve build errors wi

Re: [RFC/PATCH v1 0/4] compat/obstack: update from upstream

2019-06-14 Thread Ramsay Jones
On 14/06/2019 11:00, SZEDER Gábor wrote: > Update 'compat/obstack.{c,h}' from upstream, because they already use > 'size_t' instead of 'long' in places that might eventually end up as > an argument to malloc(), which might solve build errors with GCC 8 on > Windows. > > The first patch just imp

Re: [RFC/PATCH v1 0/4] compat/obstack: update from upstream

2019-06-14 Thread Junio C Hamano
SZEDER Gábor writes: > And here is an all-green build of these patches on Travis CI: > > https://travis-ci.org/szeder/git/builds/545645247 > > (and one bonus patch on top to deal with some Homebrew nonsense) Is this the one that making all of the jobs pass in the above output, including the ma

Re: [RFC/PATCH v1 0/4] compat/obstack: update from upstream

2019-06-14 Thread Jeff King
On Fri, Jun 14, 2019 at 12:00:55PM +0200, SZEDER Gábor wrote: > Update 'compat/obstack.{c,h}' from upstream, because they already use > 'size_t' instead of 'long' in places that might eventually end up as > an argument to malloc(), which might solve build errors with GCC 8 on > Windows. > > The f

[RFC/PATCH v1 0/4] compat/obstack: update from upstream

2019-06-14 Thread SZEDER Gábor
Update 'compat/obstack.{c,h}' from upstream, because they already use 'size_t' instead of 'long' in places that might eventually end up as an argument to malloc(), which might solve build errors with GCC 8 on Windows. The first patch just imports from upstream and doesn't modify anything at all, a