Re: [RFC/PATCH V2] branch.c: replace git_config with git_config_get_string

2014-06-29 Thread Eric Sunshine
On Thu, Jun 26, 2014 at 4:09 AM, Tanay Abhra wrote: > > On 6/25/2014 10:15 AM, Eric Sunshine wrote: >> On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: >>> diff --git a/branch.c b/branch.c >>> index 660097b..c9a2a0d 100644 >>> --- a/branch.c >>> +++ b/branch.c >>> @@ -140,33 +140,25 @@ static

Re: [RFC/PATCH V2] branch.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 10:15 AM, Eric Sunshine wrote: > On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: >> diff --git a/branch.c b/branch.c >> index 660097b..c9a2a0d 100644 >> --- a/branch.c >> +++ b/branch.c >> @@ -140,33 +140,25 @@ static int setup_tracking(const char *new_ref, const >> char *orig_

Re: [RFC/PATCH V2] branch.c: replace git_config with git_config_get_string

2014-06-24 Thread Eric Sunshine
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: > Use git_config_get_string instead of git_config to take advantage of > the config hash-table api which provides a cleaner control flow. > > Signed-off-by: Tanay Abhra > --- > branch.c | 24 > 1 file changed, 8 inserti

[RFC/PATCH V2] branch.c: replace git_config with git_config_get_string

2014-06-23 Thread Tanay Abhra
Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. Signed-off-by: Tanay Abhra --- branch.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/branch.c b/branch.c index 66