Re: [RFC/PATCH 7/7] grep: use PCRE v2 for optimized fixed-string search

Hi Junio, On Thu, 27 Jun 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> > > If we would not have plenty of exercise for the PCRE2 build > >> > > options, I would be worried. But AFAICT the CI build includes > >> > > this all the time, so we're fine. > >> > > >> > Well, I'd feel

Re: [RFC/PATCH 7/7] grep: use PCRE v2 for optimized fixed-string search

Johannes Schindelin writes: >> > > If we would not have plenty of exercise for the PCRE2 build options, I >> > > would be worried. But AFAICT the CI build includes this all the time, so >> > > we're fine. >> > >> > Well, I'd feel safer if it were not "all the time", i.e. we know we >> > are testi

Re: [RFC/PATCH 7/7] grep: use PCRE v2 for optimized fixed-string search

Hi, On Thu, 27 Jun 2019, Johannes Schindelin wrote: > On Wed, 26 Jun 2019, Junio C Hamano wrote: > > > Johannes Schindelin writes: > > > > > ... > > > Ah hah! > > > > > > If we would not have plenty of exercise for the PCRE2 build options, I > > > would be worried. But AFAICT the CI build includ

Re: [RFC/PATCH 7/7] grep: use PCRE v2 for optimized fixed-string search

Hi Junio, On Wed, 26 Jun 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > > ... > > Ah hah! > > > > If we would not have plenty of exercise for the PCRE2 build options, I > > would be worried. But AFAICT the CI build includes this all the time, so > > we're fine. > > Well, I'd feel

Re: [RFC/PATCH 7/7] grep: use PCRE v2 for optimized fixed-string search

Johannes Schindelin writes: > ... > Ah hah! > > If we would not have plenty of exercise for the PCRE2 build options, I > would be worried. But AFAICT the CI build includes this all the time, so > we're fine. Well, I'd feel safer if it were not "all the time", i.e. we know we are testing both sid

Re: [RFC/PATCH 7/7] grep: use PCRE v2 for optimized fixed-string search

Hi Ævar, On Wed, 26 Jun 2019, Ævar Arnfjörð Bjarmason wrote: > Bring back optimized fixed-string search for "grep", this time with > PCRE v2 as an optional backend. As noted in [1] with kwset we were > slower than PCRE v1 and v2 JIT with the kwset backend, so that > optimization was counterproduc

[RFC/PATCH 7/7] grep: use PCRE v2 for optimized fixed-string search

Bring back optimized fixed-string search for "grep", this time with PCRE v2 as an optional backend. As noted in [1] with kwset we were slower than PCRE v1 and v2 JIT with the kwset backend, so that optimization was counterproductive. This brings back the optimization for "-F", without changing the