Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-10 Thread Karthik Nayak
On 06/10/2015 01:09 PM, Matthieu Moy wrote: Junio C Hamano writes: > Don't do that. Always start your function like so: > > type funcname(args) > { > declarations; > > first statement; > ... Hint: create a file config.mak with this content:

Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-10 Thread Matthieu Moy
Junio C Hamano writes: > Don't do that. Always start your function like so: > > type funcname(args) > { > declarations; > > first statement; > ... Hint: create a file config.mak with this content: $ cat config.mak CFLAGS += -Wdeclaratio

Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-09 Thread Karthik Nayak
On 06/10/2015 12:37 AM, Junio C Hamano wrote: Karthik Nayak writes: >>> @@ -54,7 +59,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) >>>/* for warn_ambiguous_refs */ >>>git_config(git_default_config, NULL); >>> >>> -memset(&ref_cbdata, 0, sizeof(r

Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-09 Thread Junio C Hamano
Karthik Nayak writes: >>> @@ -54,7 +59,6 @@ int cmd_for_each_ref(int argc, const char **argv, const >>> char *prefix) >>> /* for warn_ambiguous_refs */ >>> git_config(git_default_config, NULL); >>> >>> - memset(&ref_cbdata, 0, sizeof(ref_cbdata)); >> >> I cannot quite see how this chan

Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-09 Thread Karthik Nayak
On 06/09/2015 12:42 AM, Junio C Hamano wrote: Is this intended? I would have expected if I did git for-each-ref --points-at master I would get refs/heads/master and any other refs that exactly points at that commit. Thats to be changed, thanks! FIELD NAMES --- diff -

Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-08 Thread Junio C Hamano
Karthik Nayak writes: > Add the '--points-at' option provided by 'ref-filter'. The > option lets the user to pick only refs which point to a particular > commit. > > Add Documentation for the same. > > Based-on-patch-by: Jeff King > Mentored-by: Christian Couder > Mentored-by: Matthieu Moy > S

Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-08 Thread Karthik Nayak
On 06/08/2015 11:05 PM, Matthieu Moy wrote: Karthik Nayak writes: Add the '--points-at' option provided by 'ref-filter'. The option lets the user to pick only refs which point to a particular commit. Add Documentation for the same. ... but no test? No haven't written tests, this was just

Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-08 Thread Matthieu Moy
Karthik Nayak writes: > Add the '--points-at' option provided by 'ref-filter'. The > option lets the user to pick only refs which point to a particular > commit. > > Add Documentation for the same. ... but no test? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this li

[RFC/PATCH 3/9] for-each-ref: add '--points-at' option

2015-06-06 Thread Karthik Nayak
Add the '--points-at' option provided by 'ref-filter'. The option lets the user to pick only refs which point to a particular commit. Add Documentation for the same. Based-on-patch-by: Jeff King Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak --- Document