Re: [RFC/PATCH 2/8 v2] git_remote_helpers: fix input when running under Python 3

2013-01-15 Thread Junio C Hamano
John Keeping writes: >> That really feels wrong. Displaying is a separate issue and it is >> the _right_ thing to punt the problem at the lower-level machinery >> level. > > But the display will require decoding the ref name to a Unicode string, > which depends on the encoding of the underlying

Re: [RFC/PATCH 2/8 v2] git_remote_helpers: fix input when running under Python 3

2013-01-15 Thread John Keeping
On Tue, Jan 15, 2013 at 12:51:13PM -0800, Junio C Hamano wrote: > John Keeping writes: >> Although 2to3 will fix most issues in Python 2 code to make it run under >> Python 3, it does not handle the new strict separation between byte >> strings and unicode strings. There is one instance in >> git

Re: [RFC/PATCH 2/8 v2] git_remote_helpers: fix input when running under Python 3

2013-01-15 Thread Junio C Hamano
John Keeping writes: > Although 2to3 will fix most issues in Python 2 code to make it run under > Python 3, it does not handle the new strict separation between byte > strings and unicode strings. There is one instance in > git_remote_helpers where we are caught by this, which is when reading >

[RFC/PATCH 2/8 v2] git_remote_helpers: fix input when running under Python 3

2013-01-15 Thread John Keeping
Although 2to3 will fix most issues in Python 2 code to make it run under Python 3, it does not handle the new strict separation between byte strings and unicode strings. There is one instance in git_remote_helpers where we are caught by this, which is when reading refs from "git for-each-ref". Wh