Re: [RFC/PATCH 2/2] Testing the new code

2015-08-03 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Jul 31, 2015 at 6:02 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> -module_list() >>> +module_list_shell() >>> { >>> eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")" >>> ( >>> @@ -187,6 +187,29 @@ module_list() >>> ' >

Re: [RFC/PATCH 2/2] Testing the new code

2015-08-03 Thread Stefan Beller
On Fri, Jul 31, 2015 at 6:02 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> -module_list() >> +module_list_shell() >> { >> eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")" >> ( >> @@ -187,6 +187,29 @@ module_list() >> ' >> } >> >> +module_list() >> +{ >>

Re: [RFC/PATCH 2/2] Testing the new code

2015-07-31 Thread Junio C Hamano
Stefan Beller writes: > -module_list() > +module_list_shell() > { > eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")" > ( > @@ -187,6 +187,29 @@ module_list() > ' > } > > +module_list() > +{ > + # call both the old and new code > + module_list_shell $@ >

[RFC/PATCH 2/2] Testing the new code

2015-07-31 Thread Stefan Beller
Signed-off-by: Stefan Beller --- Notes: The output of the differential testing is below, which points out 2 bugs: * resolving relative paths seems is broken, so we would need to have the equivalent of eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")" (