Re: [RFC/PATCH 0/4] duplicate objects in packfiles

2013-08-21 Thread Junio C Hamano
Jeff King writes: > Which leaves the open question: should the default for index-pack flip > to reject duplicates rather than allow? I'd say so. In am emergency, people with broken packfiles can feed them to unpack-objects ;-) More seriously, an alternative emergency mode may be an option to u

[RFC/PATCH 0/4] duplicate objects in packfiles

2013-08-21 Thread Jeff King
On Fri, Aug 16, 2013 at 11:01:38AM -0400, Jeff King wrote: > That makes me inclined to teach index-pack to reject duplicate objects > in a single pack in order to prevent denial-of-service attacks. We can > potentially make them work in all code paths, but given that nobody > should be doing this