Re: [RFC/PATCH] rm: delete .gitmodules entry of submodules removed from the work tree

2013-04-10 Thread Jonathan Nieder
Hi, Thanks for looking it over. Ramkumar Ramachandra wrote: > - Why are you hard-coding ".gitmodules" instead of using a simple #define? Advantage of ".gitmodules": it's obvious what it means. Advantage of DOT_GITMODULES: protection against spelling errors. Git has a lot of use of both styles

Re: [RFC/PATCH] rm: delete .gitmodules entry of submodules removed from the work tree

2013-04-10 Thread Ramkumar Ramachandra
Jens Lehmann wrote: > builtin/rm.c | 14 +++-- > submodule.c| 31 > submodule.h| 1 + > t/t3600-rm.sh | 72 > ++ > t/t7400-submodule-basic.sh | 14 +++-- > t/t7610-

[RFC/PATCH] rm: delete .gitmodules entry of submodules removed from the work tree

2013-04-10 Thread Jens Lehmann
Currently using "git rm" on a submodule removes the submodule's work tree from that of the superproject and the gitlink from the index. But the submodule's section in .gitmodules is left untouched, which is a leftover of the now removed submodule and might irritate users (as opposed to the setting